Make flask-assets use the new query_url_mapping stuff #30

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@tgecho
Contributor
tgecho commented Nov 7, 2012

I suppose it could just call query_url_mapping() directly, but I figured this was more future proof.

@miracle2k
Owner

Good catch, I didn't even think of that. While the tests fail in those cases where no env.url is set (the default), there is a general design decision here that I've struggled with before: When the Flask static/url system should be used, and when the webassets system should take precedence.

As it stands, the Flask system (url_for etc) is used, unless a env.load_path is set, in which case only the webassets system takes over completely.

@miracle2k miracle2k added a commit that closed this pull request Nov 19, 2012
@miracle2k Settle use of webassets load_path/directory.
Mostly, when the webassets load_path system should be used, when webassets
Environment.directory and Environment.url should be used, and when to use
the Flask static folder system is now put in writing.

The actual implementation and behaviour has changed slightly and subtly to
follow what the design sets out to do.

Various tests needed to be updated along the way.

Closes #30.
c916d31
@miracle2k miracle2k closed this in c916d31 Nov 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment