Skip to content

Conversation

@talex5
Copy link
Contributor

@talex5 talex5 commented Jul 27, 2019

@hannesm
Copy link
Member

hannesm commented Jul 27, 2019

that looks good! :)

@hannesm
Copy link
Member

hannesm commented Jul 27, 2019

(the only nit being: you should include the dependency "x509" {>= "0.7.0"} in the opam file

@talex5
Copy link
Contributor Author

talex5 commented Jul 27, 2019

(the only nit being: you should include the dependency "x509" {>= "0.7.0"} in the opam file

It's already there (in capnp-rpc-lwt.opam).

@hannesm
Copy link
Member

hannesm commented Jul 27, 2019

oops, sorry -- shouldn't read diffs before finishing coffee

@talex5 talex5 merged commit caa7243 into mirage:master Jul 30, 2019
@talex5 talex5 deleted the new-x509 branch July 30, 2019 11:57
talex5 added a commit to talex5/opam-repository that referenced this pull request Aug 26, 2019
…c-unix (0.3.3)

CHANGES:

- Update uint.uint32 to uint (@Cjen1, mirage/capnp-rpc#159).
- Update to new x509 API (@talex5, mirage/capnp-rpc#158).
- Require base64 >= 3.0.0 for capnp-rpc-mirage too (@talex5, mirage/capnp-rpc#157).
- Put test sockets in temporary directory (@talex5, mirage/capnp-rpc#156).
talex5 added a commit to talex5/opam-repository that referenced this pull request Aug 26, 2019
…c-unix (0.3.3)

CHANGES:

- Update uint.uint32 to uint (@Cjen1, mirage/capnp-rpc#159).
- Update to new x509 API (@talex5, mirage/capnp-rpc#158).
- Require base64 >= 3.0.0 for capnp-rpc-mirage too (@talex5, mirage/capnp-rpc#157).
- Put test sockets in temporary directory (@talex5, mirage/capnp-rpc#156).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants