Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new x509 API #158

Merged
merged 1 commit into from Jul 30, 2019
Merged

Update to new x509 API #158

merged 1 commit into from Jul 30, 2019

Conversation

@talex5
Copy link
Contributor

@talex5 talex5 commented Jul 27, 2019

See ocaml/opam-repository#14592 (comment)

/cc @hannesm

@hannesm
Copy link
Member

@hannesm hannesm commented Jul 27, 2019

that looks good! :)

Loading

@hannesm
Copy link
Member

@hannesm hannesm commented Jul 27, 2019

(the only nit being: you should include the dependency "x509" {>= "0.7.0"} in the opam file

Loading

@talex5
Copy link
Contributor Author

@talex5 talex5 commented Jul 27, 2019

(the only nit being: you should include the dependency "x509" {>= "0.7.0"} in the opam file

It's already there (in capnp-rpc-lwt.opam).

Loading

@hannesm
Copy link
Member

@hannesm hannesm commented Jul 27, 2019

oops, sorry -- shouldn't read diffs before finishing coffee

Loading

@talex5 talex5 merged commit caa7243 into mirage:master Jul 30, 2019
1 check passed
Loading
@talex5 talex5 deleted the new-x509 branch Jul 30, 2019
talex5 added a commit to talex5/opam-repository that referenced this issue Aug 26, 2019
…c-unix (0.3.3)

CHANGES:

- Update uint.uint32 to uint (@Cjen1, mirage/capnp-rpc#159).
- Update to new x509 API (@talex5, mirage/capnp-rpc#158).
- Require base64 >= 3.0.0 for capnp-rpc-mirage too (@talex5, mirage/capnp-rpc#157).
- Put test sockets in temporary directory (@talex5, mirage/capnp-rpc#156).
talex5 added a commit to talex5/opam-repository that referenced this issue Aug 26, 2019
…c-unix (0.3.3)

CHANGES:

- Update uint.uint32 to uint (@Cjen1, mirage/capnp-rpc#159).
- Update to new x509 API (@talex5, mirage/capnp-rpc#158).
- Require base64 >= 3.0.0 for capnp-rpc-mirage too (@talex5, mirage/capnp-rpc#157).
- Put test sockets in temporary directory (@talex5, mirage/capnp-rpc#156).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants