bugfix: look at udp_payload for dhcp flags field, not overall packet #51

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Projects
None yet
2 participants
@yomimono
Member

yomimono commented Mar 31, 2017

buf is the entire packet (with Ethernet/Ipv4/Udp headers), so while the existing code was a valid access, it's not what we're looking for.

@haesbaert

This comment has been minimized.

Show comment
Hide comment
@haesbaert

haesbaert Mar 31, 2017

Member

Wow, nice catch !

This is an embarrassing bug, I think it deserves a release actually.

Member

haesbaert commented Mar 31, 2017

Wow, nice catch !

This is an embarrassing bug, I think it deserves a release actually.

@haesbaert haesbaert merged commit 7af097e into mirage:master Mar 31, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stedolan stedolan referenced this pull request in stedolan/crowbar May 24, 2017

Open

Bugs found with Crowbar #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment