New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loop for parsing lists of 16 and 32-bit options #54

Merged
merged 2 commits into from Apr 8, 2017

Conversation

Projects
None yet
2 participants
@yomimono
Member

yomimono commented Apr 7, 2017

Crowbar noticed this (via somerandompacket); the test included here is insufficiently silly for the test suite, so suggestions for better constants that fit in better with the theme are welcome.

@@ -897,6 +937,7 @@ let run_test test =
let all_tests = [
(t_option_codes, "option codes");
(t_long_lists, "long lists of options serialize/deserialize ok");

This comment has been minimized.

@haesbaert

haesbaert Apr 8, 2017

Member

the test name is a bit too long, I'll merge and change ok ?

@haesbaert

haesbaert Apr 8, 2017

Member

the test name is a bit too long, I'll merge and change ok ?

@haesbaert haesbaert merged commit 261cdfe into mirage:master Apr 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stedolan stedolan referenced this pull request May 24, 2017

Open

Bugs found with Crowbar #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment