option parsing: continue building ip tuple list for lengths > 1 #55

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@yomimono
Member

yomimono commented Apr 10, 2017

Without this patch, we only get the first tuple from the list.

@haesbaert

This comment has been minimized.

Show comment
Hide comment
@haesbaert

haesbaert Apr 11, 2017

Member

Great finding !
I will only merge once you add yourself to the copyright 🎉

Member

haesbaert commented Apr 11, 2017

Great finding !
I will only merge once you add yourself to the copyright 🎉

@haesbaert haesbaert closed this Apr 12, 2017

@haesbaert

This comment has been minimized.

Show comment
Hide comment
@haesbaert

haesbaert Apr 12, 2017

Member

Merged, I've added you to dhcp_wire.ml and test.ml as well on the copyrights.

I'm keeping the line by line format.
I had written this message before, just can't find it. Maybe I commented out on a totally unrelated project :D

Member

haesbaert commented Apr 12, 2017

Merged, I've added you to dhcp_wire.ml and test.ml as well on the copyrights.

I'm keeping the line by line format.
I had written this message before, just can't find it. Maybe I commented out on a totally unrelated project :D

@stedolan stedolan referenced this pull request in stedolan/crowbar May 24, 2017

Open

Bugs found with Crowbar #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment