Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Re-implement UDP checksum on input. #63
The unmarshal function doesn't verify checksum, so we have to do it ourselves.
Can anyone clarify why this is not done by the unmarshal function ?
True about the IPV4 header checksum; there should be a convenience function for this like there is for TCP and UDP checksums.
It's probably possible to replace Util.guard with something from Rresult, and I think there's an Alcotest.check_raises but I don't remember whether Alcotest is already a dependency. It's not worth adding just for that.
Those are just nits though, I think this is good.