New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/anonymityprofiles #76

Merged
merged 5 commits into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@juga0
Contributor

juga0 commented Nov 30, 2017

Modifications to the packet to support the Anonymity Profiles (RFC 7844).

Thanks to @yomimono guide to find where the variables are and how to modify them.

@yomimono

This comment has been minimized.

Show comment
Hide comment
@yomimono

yomimono Dec 1, 2017

Member

The build fails with:

# Error: Unbound constructor Private_classless_static_route

#       ocamlc lib/dhcp_wire.{cmo,cmt} (exit 2)

# (cd _build/default && /home/opam/.opam/4.03.0/bin/ocamlc.opt -w -40 -g -bin-annot -I /home/opam/.opam/4.03.0/lib/bytes -I /home/opam/.opam/4.03.0/lib/cstruct -I /home/opam/.opam/4.03.0/lib/fmt -I /home/opam/.opam/4.03.0/lib/io-page -I /home/opam/.opam/4.03.0/lib/ipaddr -I /home/opam/.opam/4.03.0/lib/logs -I /home/opam/.opam/4.03.0/lib/lwt -I /home/opam/.opam/4.03.0/lib/mirage-device -I /home/opam/.opam/4.03.0/lib/mirage-flow -I /home/opam/.opam/4.03.0/lib/mirage-net -I /home/opam/.opam/4.03.0/lib/mirage-net-lwt -I /home/opam/.opam/4.03.0/lib/mirage-profile -I /home/opam/.opam/4.03.0/lib/mirage-protocols -I /home/opam/.opam/4.03.0/lib/mirage-protocols-lwt -I /home/opam/.opam/4.03.0/lib/mirage-random -I /home/opam/.opam/4.03.0/lib/ocaml -I /home/opam/.opam/4.03.0/lib/ocplib-endian -I /home/opam/.opam/4.03.0/lib/randomconv -I /home/opam/.opam/4.03.0/lib/result -I /home/opam/.opam/4.03.0/lib/rresult -I /home/opam/.opam/4.03.0/lib/sexplib -I /home/opam/.opam/4.03.0/lib/sexplib/0 -I /home/opam/.opam/4.03.0/lib/tcpip -I /home/opam/.opam/4.03.0/lib/tcpip/ethif -I /home/opam/.opam/4.03.0/lib/tcpip/ipv4 -I /home/opam/.opam/4.03.0/lib/tcpip/udp -I /home/opam/.opam/4.03.0/lib/tcpip/unix -I /home/opam/.opam/4.03.0/lib/uchar -no-alias-deps -I lib -o lib/dhcp_wire.cmo -c -impl lib/dhcp_wire.pp.ml)

# File "lib/dhcp_wire.ml", line 1519, characters 24-54:

# Error: Unbound constructor Private_classless_static_route

I think an entry for Private_classless_static_route is missing in the dhcp_option type in dhcp_wire.ml (it is present in dhcp_wire.mli, but needs to be in both the interface and the code).

Member

yomimono commented Dec 1, 2017

The build fails with:

# Error: Unbound constructor Private_classless_static_route

#       ocamlc lib/dhcp_wire.{cmo,cmt} (exit 2)

# (cd _build/default && /home/opam/.opam/4.03.0/bin/ocamlc.opt -w -40 -g -bin-annot -I /home/opam/.opam/4.03.0/lib/bytes -I /home/opam/.opam/4.03.0/lib/cstruct -I /home/opam/.opam/4.03.0/lib/fmt -I /home/opam/.opam/4.03.0/lib/io-page -I /home/opam/.opam/4.03.0/lib/ipaddr -I /home/opam/.opam/4.03.0/lib/logs -I /home/opam/.opam/4.03.0/lib/lwt -I /home/opam/.opam/4.03.0/lib/mirage-device -I /home/opam/.opam/4.03.0/lib/mirage-flow -I /home/opam/.opam/4.03.0/lib/mirage-net -I /home/opam/.opam/4.03.0/lib/mirage-net-lwt -I /home/opam/.opam/4.03.0/lib/mirage-profile -I /home/opam/.opam/4.03.0/lib/mirage-protocols -I /home/opam/.opam/4.03.0/lib/mirage-protocols-lwt -I /home/opam/.opam/4.03.0/lib/mirage-random -I /home/opam/.opam/4.03.0/lib/ocaml -I /home/opam/.opam/4.03.0/lib/ocplib-endian -I /home/opam/.opam/4.03.0/lib/randomconv -I /home/opam/.opam/4.03.0/lib/result -I /home/opam/.opam/4.03.0/lib/rresult -I /home/opam/.opam/4.03.0/lib/sexplib -I /home/opam/.opam/4.03.0/lib/sexplib/0 -I /home/opam/.opam/4.03.0/lib/tcpip -I /home/opam/.opam/4.03.0/lib/tcpip/ethif -I /home/opam/.opam/4.03.0/lib/tcpip/ipv4 -I /home/opam/.opam/4.03.0/lib/tcpip/udp -I /home/opam/.opam/4.03.0/lib/tcpip/unix -I /home/opam/.opam/4.03.0/lib/uchar -no-alias-deps -I lib -o lib/dhcp_wire.cmo -c -impl lib/dhcp_wire.pp.ml)

# File "lib/dhcp_wire.ml", line 1519, characters 24-54:

# Error: Unbound constructor Private_classless_static_route

I think an entry for Private_classless_static_route is missing in the dhcp_option type in dhcp_wire.ml (it is present in dhcp_wire.mli, but needs to be in both the interface and the code).

Show outdated Hide outdated client/dhcp_client.ml Outdated
@juga0

This comment has been minimized.

Show comment
Hide comment
@juga0

juga0 Dec 1, 2017

Contributor

I think an entry for Private_classless_static_route is missing in the dhcp_option type

Yes, it was missing. Now it should build without errors.

Contributor

juga0 commented Dec 1, 2017

I think an entry for Private_classless_static_route is missing in the dhcp_option type

Yes, it was missing. Now it should build without errors.

@yomimono yomimono merged commit b09d638 into mirage:master Dec 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment