Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp does not answer with correct ClientId #84

Open
lynxis opened this issue Oct 7, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@lynxis
Copy link

commented Oct 7, 2018

When using dhcpcd on archlinux to retrieve an address from the mirage dhcp server. The server does not respond with the correct ClientId.
dhcpc send CliendId with type 0xff,
mirage server answer with CliendId with type 0x00

lynxis added a commit to lynxis/charrua-core that referenced this issue Mar 8, 2019

Fix dhcp client id
Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.

client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!

Fixes mirage#84

Note to previous self:
 - I've no idea how I fixed it. Can you explain it?

lynxis added a commit to lynxis/charrua-core that referenced this issue Mar 8, 2019

Fix dhcp client id
Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.

client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!

Fixes mirage#84

Note to previous self:
 - I've no idea how I fixed it. Can you explain it?
@lynxis

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

doesn't work yet. works for me, but for other client id == type 0x0 it's broken.

@lynxis

This comment has been minimized.

Copy link
Author

commented Mar 15, 2019

Fixed by #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.