Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp does not answer with correct ClientId #84

Closed
lynxis opened this issue Oct 7, 2018 · 3 comments
Closed

dhcp does not answer with correct ClientId #84

lynxis opened this issue Oct 7, 2018 · 3 comments

Comments

@lynxis
Copy link

@lynxis lynxis commented Oct 7, 2018

When using dhcpcd on archlinux to retrieve an address from the mirage dhcp server. The server does not respond with the correct ClientId.
dhcpc send CliendId with type 0xff,
mirage server answer with CliendId with type 0x00

lynxis added a commit to lynxis/charrua-core that referenced this issue Mar 8, 2019
Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.

client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!

Fixes mirage#84

Note to previous self:
 - I've no idea how I fixed it. Can you explain it?
lynxis added a commit to lynxis/charrua-core that referenced this issue Mar 8, 2019
Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.

client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!

Fixes mirage#84

Note to previous self:
 - I've no idea how I fixed it. Can you explain it?
@lynxis
Copy link
Author

@lynxis lynxis commented Mar 8, 2019

doesn't work yet. works for me, but for other client id == type 0x0 it's broken.

@lynxis
Copy link
Author

@lynxis lynxis commented Mar 15, 2019

Fixed by #98

@hannesm
Copy link
Member

@hannesm hannesm commented Nov 25, 2020

now that #98 is merged, this can be closed.

@hannesm hannesm closed this as completed Nov 25, 2020
hannesm added a commit that referenced this issue Nov 25, 2020
As observed in #84, the client identifier type was set to 0 (and thus not
respecting the client which sent the identifier). This violates RFC6842,
which states that the client identifier must be replied with unmodified.
hannesm added a commit to hannesm/opam-repository that referenced this issue Nov 25, 2020
…t (1.3.0)

CHANGES:

* Revise packaging: charrua-client-lwt and charrua-client-mirage are now
  available as charrua-client.lwt and charrua-client.mirage (mirage/charrua#110 @hannesm)
* Dhcp_ipv4 directly uses Dhcp_client_mirage (instead of an abstract module
  interface being passed) (mirage/charrua#110 @hannesm)
* Fix sending of client_identifier with appropriate type as sent by the client
  (mirage/charrua#98 @hannesm, reported in mirage/charrua#84 by @lynxis)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants