Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dhcp client id #97

Closed
wants to merge 1 commit into from
Closed

Fix dhcp client id #97

wants to merge 1 commit into from

Conversation

lynxis
Copy link

@lynxis lynxis commented Mar 8, 2019

Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.

client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!

Note to previous self:

  • I've no idea how I fixed it. Can you explain it?

@lynxis
Copy link
Author

@lynxis lynxis commented Mar 8, 2019

Hi @hannesm

maybe you help me understand what I've done here. But it works ;)

Best,
lynxis

Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.

client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!

Fixes mirage#84

Note to previous self:
 - I've no idea how I fixed it. Can you explain it?
@lynxis
Copy link
Author

@lynxis lynxis commented Mar 8, 2019

Doesn't work yet. works for me, but for other client id == type 0x0 it's broken.

@lynxis
Copy link
Author

@lynxis lynxis commented Mar 15, 2019

Superseeded by #98.

@lynxis lynxis closed this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant