Fix dhcp client id #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hannesm maybe you help me understand what I've done here. But it works ;) Best, |
Clients which uses a Client Id with type 0xff could not get an dhcp lease. The Problem is in the Client Id type of 0xff. Charrua ignored the type and set it internal to 0x00. When the client sent the "Request", charrua could not find the matching Offer because of the mismatch in the client id. client | server -> DISCOVER <- OFFER -> REQUEST <- NAK! Fixes mirage#84 Note to previous self: - I've no idea how I fixed it. Can you explain it?
|
Doesn't work yet. works for me, but for other client id == type 0x0 it's broken. |
|
Superseeded by #98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.
client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!
Note to previous self: