Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix dhcp client id #97
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hi @hannesm maybe you help me understand what I've done here. But it works ;) Best, |
lynxis
force-pushed the
lynxis:master
branch
from
e27a89b
to
a4ca9c5
Mar 8, 2019
This comment has been minimized.
This comment has been minimized.
|
Doesn't work yet. works for me, but for other client id == type 0x0 it's broken. |
This comment has been minimized.
This comment has been minimized.
|
Superseeded by #98. |
lynxis
closed this
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
lynxis commentedMar 8, 2019
Clients which uses a Client Id with type 0xff could not get an
dhcp lease.
The Problem is in the Client Id type of 0xff. Charrua ignored the type
and set it internal to 0x00. When the client sent the "Request",
charrua could not find the matching Offer because of the mismatch in the client
id.
client | server
-> DISCOVER
<- OFFER
-> REQUEST
<- NAK!
Note to previous self: