Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Topkg #64

Merged
merged 11 commits into from Jul 13, 2016
Merged

Topkg #64

merged 11 commits into from Jul 13, 2016

Conversation

samoht
Copy link
Member

@samoht samoht commented Jul 13, 2016

@Drup I've removed lib/functoria_sigs.mli as it seems that nobody was using it. Do you remember what it was for?

@yallop I've got some errors running the tests:

==============================================================================
Error: Command-line parsing tests:5:describe.

File "/Users/thomas/git/functoria/_build/oUnit-Command-line parsing tests-roccapina.local#02.log", line 8, characters 1-1:
Error: Command-line parsing tests:5:describe (in the log).

Raised at file "src/oUnitAssert.ml", line 45, characters 8-27
Called from file "src/oUnitRunner.ml", line 46, characters 13-26

not equal
------------------------------------------------------------------------------
==============================================================================
Error: Command-line parsing tests:2:read_config_file.

File "/Users/thomas/git/functoria/_build/oUnit-Command-line parsing tests-roccapina.local#01.log", line 5, characters 1-1:
Error: Command-line parsing tests:2:read_config_file (in the log).

File "tests/test_functoria_command_line.ml", line 195, characters 1-1:
Error: Command-line parsing tests:2:read_config_file (in the code).

not equal
------------------------------------------------------------------------------

Do you have an idea of what it means? :-)

@samoht
Copy link
Member Author

samoht commented Jul 13, 2016

/cc @dbuenzli

@yallop
Copy link
Member

yallop commented Jul 13, 2016

I think this might need a version constraint for topkg.

@samoht
Copy link
Member Author

samoht commented Jul 13, 2016

@yallop I've added a constraint for the --pinned command-line argument support. Did you have something else in mind?

@yallop
Copy link
Member

yallop commented Jul 13, 2016

Thanks; that's fine. I initially tried to build with topkg 0.7.1 and saw mysterious failures. But I've upgraded to 0.7.6 and the build is working now.

@yallop
Copy link
Member

yallop commented Jul 13, 2016

However, make test doesn't do anything:

$ make test
ocaml pkg/pkg.ml test
pkg.ml: No tests to run.

@samoht
Copy link
Member Author

samoht commented Jul 13, 2016

@yallop ha yes, you need to remove the ~run:false in pkg/pkg.ml

@yallop
Copy link
Member

yallop commented Jul 13, 2016

@samoht: the tests are failing because there's no config.ml file:

$ make test
[... failure ...]
$ touch config.ml
$ make test
[ ... success ... ]

@samoht
Copy link
Member Author

samoht commented Jul 13, 2016

ha the tests have to run in tests/. Good catch!

@samoht samoht merged commit e5862e6 into mirage:master Jul 13, 2016
@samoht samoht deleted the topkg branch July 13, 2016 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants