New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topkg #64

Merged
merged 11 commits into from Jul 13, 2016

Conversation

Projects
None yet
2 participants
@samoht
Member

samoht commented Jul 13, 2016

@Drup I've removed lib/functoria_sigs.mli as it seems that nobody was using it. Do you remember what it was for?

@yallop I've got some errors running the tests:

==============================================================================
Error: Command-line parsing tests:5:describe.

File "/Users/thomas/git/functoria/_build/oUnit-Command-line parsing tests-roccapina.local#02.log", line 8, characters 1-1:
Error: Command-line parsing tests:5:describe (in the log).

Raised at file "src/oUnitAssert.ml", line 45, characters 8-27
Called from file "src/oUnitRunner.ml", line 46, characters 13-26

not equal
------------------------------------------------------------------------------
==============================================================================
Error: Command-line parsing tests:2:read_config_file.

File "/Users/thomas/git/functoria/_build/oUnit-Command-line parsing tests-roccapina.local#01.log", line 5, characters 1-1:
Error: Command-line parsing tests:2:read_config_file (in the log).

File "tests/test_functoria_command_line.ml", line 195, characters 1-1:
Error: Command-line parsing tests:2:read_config_file (in the code).

not equal
------------------------------------------------------------------------------

Do you have an idea of what it means? :-)

@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht
Member

samoht commented Jul 13, 2016

/cc @dbuenzli

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Jul 13, 2016

Member

I think this might need a version constraint for topkg.

Member

yallop commented Jul 13, 2016

I think this might need a version constraint for topkg.

@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht

samoht Jul 13, 2016

Member

@yallop I've added a constraint for the --pinned command-line argument support. Did you have something else in mind?

Member

samoht commented Jul 13, 2016

@yallop I've added a constraint for the --pinned command-line argument support. Did you have something else in mind?

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Jul 13, 2016

Member

Thanks; that's fine. I initially tried to build with topkg 0.7.1 and saw mysterious failures. But I've upgraded to 0.7.6 and the build is working now.

Member

yallop commented Jul 13, 2016

Thanks; that's fine. I initially tried to build with topkg 0.7.1 and saw mysterious failures. But I've upgraded to 0.7.6 and the build is working now.

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Jul 13, 2016

Member

However, make test doesn't do anything:

$ make test
ocaml pkg/pkg.ml test
pkg.ml: No tests to run.
Member

yallop commented Jul 13, 2016

However, make test doesn't do anything:

$ make test
ocaml pkg/pkg.ml test
pkg.ml: No tests to run.
@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht

samoht Jul 13, 2016

Member

@yallop ha yes, you need to remove the ~run:false in pkg/pkg.ml

Member

samoht commented Jul 13, 2016

@yallop ha yes, you need to remove the ~run:false in pkg/pkg.ml

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Jul 13, 2016

Member

@samoht: the tests are failing because there's no config.ml file:

$ make test
[... failure ...]
$ touch config.ml
$ make test
[ ... success ... ]
Member

yallop commented Jul 13, 2016

@samoht: the tests are failing because there's no config.ml file:

$ make test
[... failure ...]
$ touch config.ml
$ make test
[ ... success ... ]
@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht

samoht Jul 13, 2016

Member

ha the tests have to run in tests/. Good catch!

Member

samoht commented Jul 13, 2016

ha the tests have to run in tests/. Good catch!

@samoht samoht merged commit e5862e6 into mirage:master Jul 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@samoht samoht deleted the samoht:topkg branch Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment