Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: ensure snapshot-isolation of read-only instances #1040

Closed
samoht opened this issue Jul 15, 2020 · 2 comments
Closed

irmin-pack: ensure snapshot-isolation of read-only instances #1040

samoht opened this issue Jul 15, 2020 · 2 comments
Labels
type/bug Related to a bug

Comments

@samoht
Copy link
Member

samoht commented Jul 15, 2020

This is the counterpart of mirage/index#198

We'd like irmin-pack read-only instances to always stay valid, whatever happens. E.g. a concurrent clear + adds should not lead to valid reads in the read-only instance. To see any new values, the read-only instance should use sync.

This is a bit different from the other backends, where read-only instance can see when values are removed/added without the need for an explicit sync. But this is needed to ensure that 1/ irmin-pack read-only instances do not keep reading the file headers to check if the file have been clearer; and 3/ irmin-pack read-only instances always read valid data.

@samoht
Copy link
Member Author

samoht commented Dec 2, 2020

@icristescu is this fixed?

@samoht samoht added the type/bug Related to a bug label Dec 2, 2020
@icristescu
Copy link
Contributor

Indeed, this is covered by the tests here, here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants