Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store.History.is_empty returns true with one value stored in the graph #681

Open
aweis opened this issue May 7, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@aweis
Copy link

commented May 7, 2019

The following gist:

https://gist.github.com/aweis/883322662f7c874b38e1b352314e7a5c

prints the following:

0. is the history empty? true
setting [a,b,c]
data at [a,b,c] is Message 1
1. is the history empty? true
setting [a,b,d]
data at [a,b,c] is Message 1
data at [a,b,d] is Message 2
2. is the history empty? false

I was surprised that a single item in the history still meant that the history was empty. Is this intended behavior?

@aweis

This comment has been minimized.

Copy link
Author

commented May 7, 2019

http://mathworld.wolfram.com/EmptyGraph.html

Is this because the singleton graph is considered empty? This is unfortunate because I would expect a commit history of 1 commit to be not empty

@samoht

This comment has been minimized.

Copy link
Member

commented May 7, 2019

It's indeed surprising. I'll try to dig a bit to understand what happens.

@samoht samoht added the bug label May 7, 2019

@zshipko zshipko referenced this issue May 7, 2019

Open

Release 2.0 #658

3 of 7 tasks complete
@avsm

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Linking in some context here to @aweis' irmin-web browser prototype #677 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.