Use logs, check more interface constraints, add more tests #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
djs55
commented
Mar 6, 2016
djs55
commented
- depend on the logs library, emit logs on errors
- check that user-supplied buffers satisfy the length constraint, with test case
- add a test case to cover successfully read back previously-written data
On fatal errors (i.e. those which return a useless `Error string), we write a log message. Applications nolonger need to extract the `Error string and log it themselves. Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Before this patch we only passed in the filename, for logging purposes. We want to check alignment invariants, so we will need the full `t`. Signed-off-by: David Scott <dave.scott@docker.com>
Since we always used `Log` to log the error, before returning it as an `Error string, define and use a new function `fatalf` to do both at once. Note before we actuallly logged `End_of_file` as "info" but this was probably a mistake, since it too returned `Error string. Signed-off-by: David Scott <dave.scott@docker.com>
Before this patch several callers had no buffer to operate on so they artifically used a length of 0. This patch makes the buffer into an optional argument so these callers will simply use the default value of None. Signed-off-by: David Scott <dave.scott@docker.com>
Before this patch the I/O would fail with an EINVAL, leaving the developer to wonder what went wrong. This patch logs and returns a descriptive error message. Signed-off-by: David Scott <dave.scott@docker.com>
This is a very simple test which writes sectors full of byte x to sector x for the first 255 sectors, and then reads them back again. Signed-off-by: David Scott <dave.scott@docker.com>
Buffers should have a length equal to a multiple of sector sizes; check that errors are returned in this case. Signed-off-by: David Scott <dave.scott@docker.com>
Member
Author
|
I'm expecting appveyor to fail on this build. |
Member
Author
|
Travis is happy. |
djs55
added a commit
that referenced
this pull request
Mar 6, 2016
Use logs, check more interface constraints, add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.