Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Better parser #18
With this branch, booting on Qubes failes with:
I guess it needs some newlines added.
How do I make this work with functoria?
Oops, had forgotten about this. @dbuenzli: This parser is parsing the Xen command line, which is just presented as a single string - your point about the key value pairs, if I understand it correctly, effectively offloads the parsing onto bash by way of it providing your
There's definitely a need for some string processing, as Cmdliner needs an array of strings to process, and the Xen PV ABI only provides a single string, so something's got to do some processing. The encoding is done by whoever puts it into the xl.cfg file:
or by whoever wrote the grub config if pygrub is being used. The equivalent code in the linux kernel is here:
We could do whatever we like here - a json fragment, binio, whatever. Copying roughly what the linux kernel does seems like a reasonable idea for now.