/mirage-bootvar-xen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use astring instead of re #19

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hannesm @jonludlam @dbuenzli
@hannesm
Member

hannesm commented May 21, 2016

hello world is linked otherwise with re https://berlin.ccc.de/~hannes/mirage-console-xen.svg
@hannesm
use astring instead of re
Loading status checks…
6d967bd
@hannesm

This comment has been minimized.

Sign in to view
Member

hannesm commented May 21, 2016

this compiles for me, but please could someone check whether semantics are preserved @talex5 @MagnusS
lib/bootvar.ml
@@ -35,10 +35,10 @@ let get_cmd_line () =
let create () =
get_cmd_line () >>= fun cmd_line ->
let entries = Re_str.(split (regexp_string " ") cmd_line) in

This comment has been minimized.

Sign in to view
Copy link
@dbuenzli

dbuenzli May 21, 2016

I understand this already used to be the case but the user still has to pray he will never have to put a space or an = in a parameter value. Do you want users to hate your software ?

See #18 and the parse_env example here.

@hannesm hannesm referenced this pull request May 22, 2016

Merged

Better parser #18

@jonludlam

This comment has been minimized.

Sign in to view
Contributor

jonludlam commented May 23, 2016

Now #18 is merged this can be closed.

@jonludlam jonludlam closed this May 23, 2016

@hannesm hannesm deleted the hannesm:no-re branch May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment