Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

use astring instead of re#19

Closed
hannesm wants to merge 1 commit intomirage:masterfrom
hannesm:no-re
Closed

use astring instead of re#19
hannesm wants to merge 1 commit intomirage:masterfrom
hannesm:no-re

Conversation

@hannesm
Copy link
Copy Markdown
Member

@hannesm hannesm commented May 21, 2016

hello world is linked otherwise with re https://berlin.ccc.de/~hannes/mirage-console-xen.svg

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented May 21, 2016

this compiles for me, but please could someone check whether semantics are preserved @talex5 @MagnusS

Comment thread lib/bootvar.ml

let create () =
get_cmd_line () >>= fun cmd_line ->
let entries = Re_str.(split (regexp_string " ") cmd_line) in
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this already used to be the case but the user still has to pray he will never have to put a space or an = in a parameter value. Do you want users to hate your software ?

See #18 and the parse_env example here.

@hannesm hannesm mentioned this pull request May 22, 2016
@jonludlam
Copy link
Copy Markdown
Contributor

Now #18 is merged this can be closed.

@jonludlam jonludlam closed this May 23, 2016
@hannesm hannesm deleted the no-re branch May 23, 2016 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants