Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use astring instead of re #19

Closed
wants to merge 1 commit into from
Closed

use astring instead of re #19

wants to merge 1 commit into from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented May 21, 2016

hello world is linked otherwise with re https://berlin.ccc.de/~hannes/mirage-console-xen.svg

@hannesm
Copy link
Member Author

hannesm commented May 21, 2016

this compiles for me, but please could someone check whether semantics are preserved @talex5 @MagnusS

dbuenzli
dbuenzli reviewed May 21, 2016
View reviewed changes
lib/bootvar.ml
@@ -35,10 +35,10 @@ let get_cmd_line () =

let create () =
get_cmd_line () >>= fun cmd_line ->
let entries = Re_str.(split (regexp_string " ") cmd_line) in
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this already used to be the case but the user still has to pray he will never have to put a space or an = in a parameter value. Do you want users to hate your software ?

See #18 and the parse_env example here.

@hannesm hannesm mentioned this pull request May 22, 2016
Merged
@jonludlam
Copy link
Contributor

Now #18 is merged this can be closed.

@jonludlam jonludlam closed this May 23, 2016
@hannesm hannesm deleted the no-re branch May 23, 2016 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hannesm @jonludlam @dbuenzli