Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use implicit executable dependency for discover.exe #46

Merged
merged 1 commit into from Nov 19, 2020

Conversation

TheLortex
Copy link
Member

Explicit executable dependencies make dune fail in cross-compilation settings.
More info in ocaml/dune#3917.

Copy link
Member

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinosaure dinosaure merged commit dcef84b into mirage:master Nov 19, 2020
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Nov 19, 2020
…k-unix (3.1.0)

CHANGES:

* Use implicit executable dependency for discover.exe
  into the dune file (mirage/mirage-clock#46 @TheLortex)
* Fix cross-compilation on Android (mirage/mirage-clock#45 @EduardoRFS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants