New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use topkg #41

Merged
merged 1 commit into from Nov 12, 2016

Conversation

Projects
None yet
3 participants
@samoht
Member

samoht commented Jul 14, 2016

  • switch to topkg
  • remove camlp4
  • split into multiple opam packages
opam packages ocamlfind libraries
mirage-console-unix mirage-console-unix
mirage-console-xen mirage-console-xen
mirage-console-backend mirage-console-backend
mirage-console-proto mirage-console-proto
mirage-console-cli mirage-console-cli
@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht

samoht Jul 14, 2016

Member

/cc @dbuenzli

@avsm are you ok with the removal of depopts and the split into multiple opam packages? I think it puts less magic in the build system and make it easier to understand which depopts is used for what.

Member

samoht commented Jul 14, 2016

/cc @dbuenzli

@avsm are you ok with the removal of depopts and the split into multiple opam packages? I think it puts less magic in the build system and make it easier to understand which depopts is used for what.

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Jul 14, 2016

Member
  • mirage-console-proto needs to become mirage-console-xen-proto
  • mirage-console-backend needs to become mirage-console-xen-backend
  • mirage-console-cli needs to be become mirage-console-xen-cli

See also djwillia/solo5#36 for other mirage-console solo5 libraries that are incoming with a similar split, but in a different repo -- this needs to be topkg'ed up as well but I can do that.

Member

avsm commented Jul 14, 2016

  • mirage-console-proto needs to become mirage-console-xen-proto
  • mirage-console-backend needs to become mirage-console-xen-backend
  • mirage-console-cli needs to be become mirage-console-xen-cli

See also djwillia/solo5#36 for other mirage-console solo5 libraries that are incoming with a similar split, but in a different repo -- this needs to be topkg'ed up as well but I can do that.

@avsm avsm referenced this pull request Jul 14, 2016

Closed

[tracking] Upstream Mirage/Solo5 #36

10 of 10 tasks complete
@hannesm

This comment has been minimized.

Show comment
Hide comment
@hannesm

hannesm Oct 1, 2016

Member

can we move forward with this @samoht ? the parts I'm mostly in favour of are getting rid of camlp4 and moving to topkg... @avsm seems to want some more renaming

Member

hannesm commented Oct 1, 2016

can we move forward with this @samoht ? the parts I'm mostly in favour of are getting rid of camlp4 and moving to topkg... @avsm seems to want some more renaming

@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht

samoht Nov 9, 2016

Member

I've rebased my initial PR, I have renamed the libraries as @avsm requested, e.g:

opam packages ocamlfind libraries
mirage-console-unix mirage-console-unix
mirage-console-xen mirage-console-xen
mirage-console-xen-backend mirage-console-xen-backend
mirage-console-xen-proto mirage-console-xen-proto
mirage-console-xen-cli mirage-console-xen-cli
Member

samoht commented Nov 9, 2016

I've rebased my initial PR, I have renamed the libraries as @avsm requested, e.g:

opam packages ocamlfind libraries
mirage-console-unix mirage-console-unix
mirage-console-xen mirage-console-xen
mirage-console-xen-backend mirage-console-xen-backend
mirage-console-xen-proto mirage-console-xen-proto
mirage-console-xen-cli mirage-console-xen-cli
Spring cleanups
- switch to topkg
- remove camlp4
- split into multiple opam packages
@samoht

This comment has been minimized.

Show comment
Hide comment
@samoht

samoht Nov 11, 2016

Member

@hannesm All green again!

Member

samoht commented Nov 11, 2016

@hannesm All green again!

@hannesm

This comment has been minimized.

Show comment
Hide comment
@hannesm

hannesm Nov 11, 2016

Member

thanks! I suspect we'll need to get the new packages into mirage-dev repo (I wouldn't invest time to backport this to Mirage2 (and cut releases), but rather work on an imminent Mirage3 release)

Member

hannesm commented Nov 11, 2016

thanks! I suspect we'll need to get the new packages into mirage-dev repo (I wouldn't invest time to backport this to Mirage2 (and cut releases), but rather work on an imminent Mirage3 release)

@hannesm hannesm merged commit 09d2dea into mirage:master Nov 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced Nov 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment