Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new grant interface in mirage-xen #75

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@yomimono
Copy link
Member

commented Mar 25, 2019

No description provided.

@talex5
Copy link
Contributor

left a comment

The disconnect function will need to be implemented too (for non-default consoles), as the new API won't automatically free exported pages when they're GC'd (and also you don't want to leak the grant ref, which it looks like the existing code does).

(also, would be nice to squash the commits to make git bisect work better, if we need it; I assume that the first commit doesn't build on its own)

Show resolved Hide resolved xen/console_xen.ml Outdated
Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved mirage-console-xen-backend.opam Outdated
@avsm

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

If I remember, you want to be a little careful with freeing the default console as dom0's xenconsoled used to get rather unhappy if it was closed before the domain disappeared. I haven't tested this on modern xenconsoled though.

@yomimono yomimono force-pushed the yomimono:new-gnt-iface branch from a84be53 to 04fe0d8 Mar 25, 2019

@talex5

talex5 approved these changes Mar 26, 2019

@yomimono yomimono merged commit 5f5ed14 into mirage:master Mar 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yomimono yomimono deleted the yomimono:new-gnt-iface branch Mar 27, 2019

yomimono added a commit to yomimono/opam-repository that referenced this pull request Mar 27, 2019

[new release] mirage-console-lwt, mirage-console-xen-backend, mirage-…
…console-xen, mirage-console, mirage-console-xen-proto and mirage-console-unix (v2.4.2)

CHANGES:

* Use new grant API from mirage-xen instead of xen-gnt (mirage/mirage-console#75 @yomimono)

yomimono added a commit to yomimono/opam-repository that referenced this pull request Apr 5, 2019

[new release] mirage-console-lwt, mirage-console-xen-backend, mirage-…
…console-xen, mirage-console, mirage-console-xen-proto and mirage-console-unix (v2.4.2)

CHANGES:

* Use new grant API from mirage-xen instead of xen-gnt (mirage/mirage-console#75 @yomimono)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.