Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new grant interface in mirage-xen #75

Merged
merged 2 commits into from Mar 27, 2019
Merged

Conversation

@yomimono
Copy link
Contributor

@yomimono yomimono commented Mar 25, 2019

No description provided.

Copy link
Contributor

@talex5 talex5 left a comment

The disconnect function will need to be implemented too (for non-default consoles), as the new API won't automatically free exported pages when they're GC'd (and also you don't want to leak the grant ref, which it looks like the existing code does).

(also, would be nice to squash the commits to make git bisect work better, if we need it; I assume that the first commit doesn't build on its own)

xen/console_xen.ml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
mirage-console-xen-backend.opam Outdated Show resolved Hide resolved
@avsm
Copy link
Member

@avsm avsm commented Mar 25, 2019

If I remember, you want to be a little careful with freeing the default console as dom0's xenconsoled used to get rather unhappy if it was closed before the domain disappeared. I haven't tested this on modern xenconsoled though.

talex5
talex5 approved these changes Mar 26, 2019
@yomimono yomimono merged commit 5f5ed14 into mirage:master Mar 27, 2019
1 check passed
@yomimono yomimono deleted the new-gnt-iface branch Mar 27, 2019
yomimono added a commit to yomimono/opam-repository that referenced this issue Mar 27, 2019
…console-xen, mirage-console, mirage-console-xen-proto and mirage-console-unix (v2.4.2)

CHANGES:

* Use new grant API from mirage-xen instead of xen-gnt (mirage/mirage-console#75 @yomimono)
yomimono added a commit to yomimono/opam-repository that referenced this issue Apr 5, 2019
…console-xen, mirage-console, mirage-console-xen-proto and mirage-console-unix (v2.4.2)

CHANGES:

* Use new grant API from mirage-xen instead of xen-gnt (mirage/mirage-console#75 @yomimono)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants