pk/rsa: use correct invariant when checking parameter d#100
Merged
Conversation
It's d parameter is bigger than e ^ -1 mod LCM (p - 1) (q - 1) which is licit as long as d and e ^ - 1 are congruent with respect of LCM (p - 1) (q - 1). Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
The previous invariant didn't apply the modulus to d, which made it fail on some valid keys. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Member
|
thanks |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jan 21, 2021
…age-crypto-rng-mirage and mirage-crypto-rng-async (0.8.10) CHANGES: - Rsa.priv: require 1 = d * e mod (lam n). This allows interoperability with OpenSSL generated keys. Reported and fixed by @psafont in mirage/mirage-crypto#100.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct invariant is
d ≡ e⁻¹ (mod λ(n)), this means that the modulus is applied to bothdande⁻¹, which was not done with the previous check.In practice this means that RSA keys using
d = (p - 1) * (q - 1)instead ofd = lcm (p - 1) (q - 1)could fail this test when they are valid.Note: (FIPS 186-4 is more strict and would use the check previously used, but I think it should be an optional check)