Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirage-crypto-ec: fix regression in Dsa.verify if r or s are short #117

Merged
merged 1 commit into from Apr 4, 2021

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Apr 4, 2021

Their byte length may be shorter than the modulus n. Previously this lead to an
exception. Now r and s are zero-padded (on the left). A regression test
(out of experiments with X.509) is added.

Also, remove size checks from the wycheproof tests (superfluous).

Their byte length may be shorter than the modulus n. Previously this lead to an
exception. Now r and s are zero-padded (on the left). A regression test
(out of experiments with X.509) is added.

Also, remove size checks from the wycheproof tests (superfluous).
@hannesm hannesm merged commit 57b0e4f into mirage:main Apr 4, 2021
@hannesm hannesm deleted the ec-fix branch April 4, 2021 17:56
hannesm added a commit to hannesm/opam-repository that referenced this pull request Apr 4, 2021
…ge-crypto-rng, mirage-crypto-rng-mirage and mirage-crypto-rng-async (0.9.1)

CHANGES:

- mirage-crypto-ec: fix ECDSA verify if r or s are shorter than the modulus
  (mirage/mirage-crypto#117 by @hannesm)
- Fixed esy cross-compile CI (mirage/mirage-crypto#116 by @EduardoRFS)

(mark mirage-crypto-ec 0.9.0 as unavailable due to the bug fixed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant