mirage-crypto-ec: fix regression in Dsa.verify if r or s are short #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their byte length may be shorter than the modulus n. Previously this lead to an exception. Now r and s are zero-padded (on the left). A regression test (out of experiments with X.509) is added. Also, remove size checks from the wycheproof tests (superfluous).
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 4, 2021
…ge-crypto-rng, mirage-crypto-rng-mirage and mirage-crypto-rng-async (0.9.1) CHANGES: - mirage-crypto-ec: fix ECDSA verify if r or s are shorter than the modulus (mirage/mirage-crypto#117 by @hannesm) - Fixed esy cross-compile CI (mirage/mirage-crypto#116 by @EduardoRFS) (mark mirage-crypto-ec 0.9.0 as unavailable due to the bug fixed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their byte length may be shorter than the modulus n. Previously this lead to an
exception. Now r and s are zero-padded (on the left). A regression test
(out of experiments with X.509) is added.
Also, remove size checks from the wycheproof tests (superfluous).