Fix x25519 and ed25519 if Cstruct with off <> 0 is given as input#118
Merged
hannesm merged 2 commits intomirage:mainfrom Apr 8, 2021
Merged
Fix x25519 and ed25519 if Cstruct with off <> 0 is given as input#118hannesm merged 2 commits intomirage:mainfrom
hannesm merged 2 commits intomirage:mainfrom
Conversation
…ffset <> 0 when passing a Cstruct.buffer to C, we need to ensure that either offset = 0 or take that offset into account (adding that to the pointer). Enhance tests of X25519, Ed25519, ECDSA, and ECDH with such a case (to avoid problems in the future).
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 8, 2021
…ge-crypto-rng, mirage-crypto-rng-mirage and mirage-crypto-rng-async (0.9.2) CHANGES: - mirage-crypto-ec: fix X25519 and Ed25519 if called with Cstruct.t whose offset is not equal to 0. Add unit tests to avoid the same issue in the future (mirage/mirage-crypto#118 by @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like I'm always making the same mistakes (and should really find (or develop) tooling which is more strict when passing pointers from OCaml to C): when passing a Cstruct.t (well, the underlying buffer), take care to add the "off" to the pointer. I reviewed the Mirage_crypto_ec module (with the assumption that Cstruct.create will always create something with off = 0) and couldn't find more cases where the off needs to be added (the tradeoff is clearly "number of arguments passed from OCaml to C").
Anyways, this PR contains some fixes, and when I reviewed the NIST curves I spotted some easy small pieces where to avoid allocations.