Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new test_entropy: testing bootstrap function and timer (cycle counter) to not produce the same output on two subsequent calls #78

merged 4 commits into from Jul 27, 2020


Copy link

@hannesm hannesm commented Jul 27, 2020

… the same

 output on two subsequent calls

rename test_entropy to test_entropy_collection
hannesm referenced this pull request Jul 27, 2020
Implementation of rtdsc based on clang's builtin version and
from gperftools at

Fixes #75
Copy link
Member Author

hannesm commented Jul 27, 2020

NB for fixing #77, I manually ran readelf -s _build/default/src/libmirage_crypto_stubs.a | grep GLOBAL | grep -v ' mc_' | grep -v ' _mc_' | grep -v ' UND ' to ensure that there aren't any non-_mc_ or non-mc_ prefixed global symbols leaking.

Copy link

@avsm avsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm also!

kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this pull request Jul 28, 2020
…mirage-crypto-rng-mirage (0.8.3)


* Fix ppc64le cycle_counter (add missing Val_long) (mirage/mirage-crypto#78 @hannesm)
  - test_entropy is now test_entropy_collection
  - test_entropy checks timer and bootstrap functions
* Avoid polluting symbol table with global non-prefixed symbols
  (reported by @anmonteiro in mirage/mirage-crypto#77, fixed mirage/mirage-crypto#78 @hannesm (suggested by @dinosaure))
* Avoid "caml_" prefix in entropy_stubs, use "mc_" instead (mirage/mirage-crypto#78 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants