mirage-crypto: chacha20 avoid accessing memory which is not mapped#83
Merged
hannesm merged 1 commit intomirage:masterfrom Aug 30, 2020
Merged
mirage-crypto: chacha20 avoid accessing memory which is not mapped#83hannesm merged 1 commit intomirage:masterfrom
hannesm merged 1 commit intomirage:masterfrom
Conversation
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Aug 30, 2020
…mirage-crypto-rng-mirage (0.8.5) CHANGES: * Avoid accessing unmapped memory in ChaCha20 (mirage/mirage-crypto#83 by @hannesm, introduced in 0.8.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this avoid accessing memory which is not necessarily ours. without this fix, segmentation faults may be triggered.
the issue if the encrypted data is not of block size (=64 byte), processing the last buffer will access up to 63 byte of memory which is not properly mapped.
bug is present since introduction of chacha20 in 0.8.1.