Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirage-crypto-rng: revise Entropy.cpu_rng to delay entropy feeding. #95

merged 1 commit into from Jan 1, 2021


Copy link

@hannesm hannesm commented Dec 29, 2020

This fixes #94, since register_source is called only once for the rdrand task.

This fixes mirage#94, since register_source is called only once for the rdrand task.
Copy link
Member Author

hannesm commented Dec 29, 2020

@EduardoRFS as I don't understand esy too well, could you briefly look into the cross-compilation CI failure? to me it looks that it tries to build with a released / master version, and fails since the interface changed...

Copy link

@hannesm feel free to merge, I will fix it in a couple of hours, this CI style isn't great

@hannesm hannesm merged commit e19f327 into mirage:master Jan 1, 2021
1 of 2 checks passed
@hannesm hannesm deleted the fix-94 branch January 1, 2021 19:38
kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this pull request Jan 4, 2021
…age-crypto-rng-mirage and mirage-crypto-rng-async (0.8.8)


- new package mirage-crypto-rng-async, entropy feeding using async (mirage/mirage-crypto#90 @seliopou)
- Entropy.cpu_rng and Entropy.cpu_rng_bootstrap result in Error `Not_supported
  on CPUs without RDRAND/RDSEED support (previously an exception was raised
  in cpu_rng_bootstrap, and cpu_rng resulted in a no-op) (mirage/mirage-crypto#92 @seliopou)
- Entropy.cpu_rng delays entropy feeding (returns unit -> unit instead of unit).
  This fixes a memory leak, reported by @talex5 mirage/mirage-crypto#94, fixed in mirage/mirage-crypto#95 by @hannesm
- Avoid illegal instructions on X86 CPUs without SSSE3 instruction set. Both
  SHA256 and ChaCha used PSHUFB which is not available on e.g. AMD Phenom II
  (report mirage/mirage-crypto#93 by @dinosaure @samoht @pirbo @RichAyotte @sebeec, fixed in mirage/mirage-crypto#96 by
Copy link

The CI should be green for the next run, this was fixed by esy-ocaml/esy-opam-override#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Memory leak in RNG _sources?
2 participants