mirage-crypto-rng: revise Entropy.cpu_rng to delay entropy feeding. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes mirage#94, since register_source is called only once for the rdrand task.
|
@EduardoRFS as I don't understand esy too well, could you briefly look into the cross-compilation CI failure? to me it looks that it tries to build with a released / master version, and fails since the interface changed... |
|
@hannesm feel free to merge, I will fix it in a couple of hours, this CI style isn't great |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jan 4, 2021
…age-crypto-rng-mirage and mirage-crypto-rng-async (0.8.8) CHANGES: - new package mirage-crypto-rng-async, entropy feeding using async (mirage/mirage-crypto#90 @seliopou) - Entropy.cpu_rng and Entropy.cpu_rng_bootstrap result in Error `Not_supported on CPUs without RDRAND/RDSEED support (previously an exception was raised in cpu_rng_bootstrap, and cpu_rng resulted in a no-op) (mirage/mirage-crypto#92 @seliopou) - Entropy.cpu_rng delays entropy feeding (returns unit -> unit instead of unit). This fixes a memory leak, reported by @talex5 mirage/mirage-crypto#94, fixed in mirage/mirage-crypto#95 by @hannesm - Avoid illegal instructions on X86 CPUs without SSSE3 instruction set. Both SHA256 and ChaCha used PSHUFB which is not available on e.g. AMD Phenom II (report mirage/mirage-crypto#93 by @dinosaure @samoht @pirbo @RichAyotte @sebeec, fixed in mirage/mirage-crypto#96 by @hannesm)
|
The CI should be green for the next run, this was fixed by esy-ocaml/esy-opam-override#86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #94, since register_source is called only once for the rdrand task.