Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of d = e^-1 mod lam n, with lam = lcm (p - 1) (q - 1) #99

merged 1 commit into from Jan 20, 2021


Copy link

@hannesm hannesm commented Jan 20, 2021

Spotted by @psafont

This is an alternate fix for #62, and adheres to RFC 8017 (etc.), NIST.

Copy link

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a unit-test derived from the key in #62 to validate this?

Copy link
Member Author

hannesm commented Jan 20, 2021

@psafont sure, added in 17eaa2d

Spotted by @psafont

This is an alternate fix for mirage#62, and adheres to RFC 8017 and NIST.
Added private key from mirage#62 as regression.

@hannesm hannesm merged commit 08cb068 into mirage:master Jan 20, 2021
2 checks passed
@hannesm hannesm deleted the rsa branch January 20, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants