Allow cancelling input #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2016
Member
|
LGTM, needs a rebase |
Without this patch, canceling the thread produced by `Netif.listen` had no effect. After this patch, canceling `Netif.listen` causes the thread to return with `Error `Disconnected`, but does not make the underlying device unusable for future calls to `listen` or `write`.
yomimono
force-pushed
the
allow-cancelling-input
branch
from
bc55f4a to
0a602b6
Compare
Contributor
Author
|
Thanks @hannesm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @samoht - this is a
mirage-net-unix-side solution to the problem discovered in mirage/mirage#743 , which is exposed because the new DHCP client code callslistento perform the DHCP lease transaction then cancels the first listener before initializing the unikernel.