Repository navigation
Use Logs library for logging - #199
Merged
Merged
Conversation
Note: to avoid breaking the API, this patch does not yet remove the console arguments from the public API.
Contributor
|
Looks great to me! Thanks! |
Member
|
this is great! I'm uncertain about choice of log levels (should we come up with some guidelines? is info a reasonable default for all the messages?). and there's still a custom logging framework in tcp https://github.com/mirage/mirage-tcpip/blob/master/tcp/log.ml -- which should now use logs, shouldn't it? |
Contributor
Author
|
I kept most of them at info to avoid changing the behaviour too much in this PR, but feel free to make additional PRs to discuss adjustments to them. The pre-existing logging does some stats too, so might need a bit of adjusting to move it over (but would be welcome I think). @samoht knows more about this... |
samoht
pushed a commit
to samoht/mirage-tcpip
that referenced
this pull request
Apr 4, 2017
Use Logs library for logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: to avoid breaking the API, this patch does not yet remove the (now-unused) console arguments from the signatures. This is so that this patch can be merged quickly to avoid creating more conflicts with other refactoring work going on.