Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use Logs library for logging #199
this is great! I'm uncertain about choice of log levels (should we come up with some guidelines? is info a reasonable default for all the messages?). and there's still a custom logging framework in tcp https://github.com/mirage/mirage-tcpip/blob/master/tcp/log.ml -- which should now use logs, shouldn't it?
I kept most of them at info to avoid changing the behaviour too much in this PR, but feel free to make additional PRs to discuss adjustments to them.
The pre-existing logging does some stats too, so might need a bit of adjusting to move it over (but would be welcome I think). @samoht knows more about this...