New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid float in RTO calculations #295

Merged
merged 4 commits into from Mar 3, 2017

Conversation

Projects
None yet
4 participants
@mattgray
Contributor

mattgray commented Mar 2, 2017

Now we have MCLOCK and int64 , we don't want to go back and forth between float when we calculate smoothed RTT, RTT variance and the retransmission timeout. This patch removes float in those local calculations. Written by @olleolleolle and me in Marrakech

mattgray and others added some commits Mar 2, 2017

Test for the rto calculation
Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
Avoid float in RTO calculations
Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
Make implementation resemble RFC arithmatic
Add note pointing to RFC section
Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
@yomimono

This comment has been minimized.

Show comment
Hide comment
@yomimono

yomimono Mar 3, 2017

Member

Thank you very much @mattgray and @olleolleolle for this excellent PR, and in particular for the attached tests.

Member

yomimono commented Mar 3, 2017

Thank you very much @mattgray and @olleolleolle for this excellent PR, and in particular for the attached tests.

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Mar 3, 2017

Member

This is so awesome!

Member

avsm commented Mar 3, 2017

This is so awesome!

@yomimono yomimono merged commit 10c8cf0 into mirage:master Mar 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hannesm

This comment has been minimized.

Show comment
Hide comment
@hannesm

hannesm Mar 3, 2017

Member

Great work, thanks so much!

Member

hannesm commented Mar 3, 2017

Great work, thanks so much!

samoht pushed a commit that referenced this pull request Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment