Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old ocaml-gnt package #12

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

@talex5
Copy link
Contributor

@talex5 talex5 commented Apr 7, 2019

This allows us to remove some unused C stubs and means that we are now free to update the C functions without having to keep them in sync with ocaml-gnt.

The list of free grant refs is now kept in this module (the new code is just copied from ocaml-gnt, with the tests for Unix removed).

Attempting to link a unikernel that uses ocaml-gnt will now fail with e.g.

undefined reference to `stub_gnttab_init'

This is intended, since we would otherwise have two modules trying to track the free grant IDs. ocaml-gnt has marked all of the Xen-specific functions as deprecated (mirage/ocaml-gnt#36), so users should get a more useful error from the compiler before getting to this stage, unless they used only the part of the API shared with Unix.

We should probably make a new release of ocaml-gnt before merging this, to ensure that users see the deprecation message.

@yomimono
Copy link
Contributor

@yomimono yomimono commented Apr 7, 2019

Once mirage/ocaml-gnt#37 is merged I'll cut 4.0.0 releases of those packages.

@yomimono
Copy link
Contributor

@yomimono yomimono commented Apr 8, 2019

PR for release of xen-gnt and xen-gnt-unix at ocaml/opam-repository#13853 .

@hannesm
Copy link
Member

@hannesm hannesm commented Apr 13, 2019

the gnt 4.0.0. is now merged, once you rebase onto master to avoid dune 1.9.1, the CI should turn green! :)

This allows us to remove some unused C stubs and means that we are now
free to update the C functions without having to keep them in sync with
ocaml-gnt.

The list of free grant refs is now kept in this module (the new code is
just copied from ocaml-gnt, with the tests for Unix removed).

Attempting to link a unikernel that uses ocaml-gnt will now fail with
e.g.

    undefined reference to `stub_gnttab_init'

This is intended, since we would otherwise have two modules trying to
track the free grant IDs. ocaml-gnt has marked all of the Xen-specific
functions as deprecated, so users should get a more useful error from
the compiler before getting to this stage, unless they used only the
part of the API shared with Unix.
@talex5
Copy link
Contributor Author

@talex5 talex5 commented Apr 14, 2019

OK, rebased.

@yomimono yomimono merged commit ba1257a into mirage:master Apr 16, 2019
1 check passed
yomimono added a commit to yomimono/opam-repository that referenced this issue Apr 25, 2019
CHANGES:

* Drop support for old ocaml-gnt package (mirage/mirage-xen#12, by @talex5)
* require dune, and conflict with broken version 1.9.1 (mirage/mirage-xen#13, by @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants