New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Xen linker options from ocamlfind xen_linkopts variables #332

Merged
merged 2 commits into from Dec 8, 2014

Conversation

Projects
None yet
2 participants
@talex5
Contributor

talex5 commented Dec 2, 2014

Before, we used the normal linker flags, but we want to share compiled
OCaml libraries between Unix and Xen while having separate C stubs.
Accidentally linking in Unix C stubs on Xen is bad on x86_64 because
Unix stubs normally assume the red zone is available. ocamlopt currently
misses this optimisation and therefore OCaml code can be shared. We
might want to revisit this design once OPAM supports cross-compiling.

talex5 added some commits Nov 27, 2014

Get Xen linker options from ocamlfind xen_linkopts variables
Before, we used the normal linker flags, but we want to share compiled
OCaml libraries between Unix and Xen while having separate C stubs.
Accidentally linking in Unix C stubs on Xen is bad on x86_64 because
Unix stubs normally assume the red zone is available. ocamlopt currently
misses this optimisation and therefore OCaml code can be shared. We
might want to revisit this design once OPAM supports cross-compiling.

@talex5 talex5 changed the title from [Tracking] Get Xen linker options from ocamlfind xen_linkopts variables to Get Xen linker options from ocamlfind xen_linkopts variables Dec 8, 2014

@talex5

This comment has been minimized.

Contributor

talex5 commented Dec 8, 2014

This is now ready to merge. I think the only packages that provided C stubs for Xen were tcpip and mirage-profile. tcpip 2.1.0 uses the new system and mirage-profile 0.3 no longer uses C stubs on Xen.

(openlibm should also be updated - mirage/mirage-xen-minios#10 - but that can be done independently)

@avsm

This comment has been minimized.

Member

avsm commented Dec 8, 2014

Looks good to me -- does nocrypto now require a patch to finally get the TLS library compiling? (and the heavens shall sing)

@avsm avsm merged commit fe6dc8a into mirage:master Dec 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@talex5 talex5 deleted the talex5:xen_linkopts branch Dec 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment