Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topkg #558

Merged
merged 12 commits into from Oct 3, 2016
Merged

Topkg #558

merged 12 commits into from Oct 3, 2016

Conversation

@samoht
Copy link
Member

samoht commented Jul 13, 2016

Switch to topkg. At the same time, simplify the packaging to get ride of the depopts. When now have 3 packages instead of 2 packages (+1 virtual package):

opam name new ocamlfind name old ocamlfind names
mirage mirage mirage
mirage-types mirage-types mirage-types, mirage-types.lwt
mirage-types-lwt mirage-types-lwt

So users of mirage-types.lwt will have to change to mirage-types-lwt.

@samoht
Copy link
Member Author

samoht commented Jul 13, 2016

Also, I've removed the lib_tests directory which seemed unused (/cc @Drup who seems to have committed some stuff in there in the last 3 years).

/cc @dbuenzli

@yomimono
Copy link
Contributor

yomimono commented Jul 13, 2016

The contents of lib_test seem to be an outdated mirror of mirage-skeleton, and I think I dimly remember a conversation with @Drup to this effect -- removing them seems sensible to me.

@samoht samoht force-pushed the samoht:topkg branch from 545245e to 9a019e8 Jul 13, 2016
@samoht samoht force-pushed the samoht:topkg branch from bee8e4e to b2829d4 Jul 13, 2016
@Drup
Copy link
Member

Drup commented Jul 20, 2016

I confirm the remarks about lib_test ... I actually though I removed it already.

@avsm
Copy link
Member

avsm commented Sep 13, 2016

This is a big change due to the ocamlfind naming change, so it needs to go in soon. I've resolved the merge conflict in #590

@avsm avsm merged commit 9f190fe into mirage:master Oct 3, 2016
0 of 27 checks passed
0 of 27 checks passed
ci/datakit/OCaml 4.03.0+flambda Skipped
Details
ci/datakit/OCaml 4.04.0+trunk Depfail
Details
ci/datakit/alpine-3.4_ocaml-4.03.0-revdeps Depfail
Details
ci/datakit/centos-7_ocaml-4.03.0 Depfail
Details
ci/datakit/debian-stable_ocaml-4.03.0 Depfail
Details
ci/datakit/debian-testing_ocaml-4.02.3 Depfail
Details
ci/datakit/fedora-24_ocaml-4.03.0 Depfail
Details
ci/datakit/mergable Depfail
Details
ci/datakit/minimal ERR (1 build)
Details
ci/datakit/opensuse-42.1_ocaml-4.03.0 Depfail
Details
ci/datakit/phase1 ERR (1 build)
Details
ci/datakit/phase2 ERR (7 builds)
Details
ci/datakit/ubuntu-16.04_ocaml-4.03.0 Depfail
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/datakit/Alpine 3.4 Building c9cdc8351e3c83dd559ff26740ef55b1
Details
ci/datakit/CentOS 7 Blocked
Details
ci/datakit/Debian Stable Blocked
Details
ci/datakit/Debian Testing Blocked
Details
ci/datakit/Fedora 24 Blocked
Details
ci/datakit/OCaml 4.02.3 Blocked
Details
ci/datakit/OCaml 4.03.0_flambda Blocked
Details
ci/datakit/OCaml 4.04.0 Blocked
Details
ci/datakit/OpenSUSE 42.1 Blocked
Details
ci/datakit/Revdeps Blocked
Details
ci/datakit/Ubuntu 16.04 Blocked
Details
ci/datakit/alpine-3.4_ocaml-4.03.0 Wait alpine-3.4_ocaml-4.03.0
Details
ci/pinataci Building container for eb6be1c0d6bc32a26b84ddc6e9d363d9
Details
avsm added a commit that referenced this pull request Oct 3, 2016
[followon #558] Topkg port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MirageOS 3
In Progress
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.