Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libvirt.xml for virtio configuration target #903

Merged
merged 2 commits into from May 23, 2018

Conversation

Projects
None yet
2 participants
@bramford
Copy link
Contributor

bramford commented May 17, 2018

As per this discussion, an example libvirt.xml file should be emitted when configuring virtio unikernels (as they are with xen).

I've tested the example output including clock, network and console devices. The only virtio feature that isn't demonstrated is block devices which don't appear to be supported by mirage for virtio.

@hannesm

This comment has been minimized.

Copy link
Member

hannesm commented May 17, 2018

thanks! I think block devices are supported by solo5/virtio (@ricarkol didn't you use them for some benchmarks?)? at least in the solo5 project there is a kernel/virtio/virtio_blk.c file around. why did you conclude that they are not supported?

@bramford

This comment has been minimized.

Copy link
Contributor Author

bramford commented May 17, 2018

@hannesm I already knew that solo5/virtio supports block but found block_of_file from mirage.mli confusing for the virtio case (with libvirt). After further testing, I found that the path to the block file (in the VM) is irrelevant as solo5/virtio only supports one device and therefore just grabs the first block device it finds regardless of name.

I've updated the PR to include the block example. Is it ok to have two commits or should I just squash them?

I'll also have a look at what would make the mirage block interface easier for this case. Maybe just some better documentation would be enough.

@bramford

This comment has been minimized.

Copy link
Contributor Author

bramford commented May 17, 2018

Actually, following on from my previous comment, I've just seen #890 and the comments within. Looks like the block configuration interface will change in the near future anyway.

@hannesm

This comment has been minimized.

Copy link
Member

hannesm commented May 23, 2018

thanks, this looks good to me!

@hannesm hannesm merged commit a6b1aa6 into mirage:master May 23, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.