Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more efficient datastructure for entity → UTF-8 conversion #60

Merged
merged 6 commits into from Jan 25, 2015

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Jan 24, 2015

No description provided.

@Chris00
Copy link
Contributor Author

Chris00 commented Jan 25, 2015

I did not see xhtml.ml before sending this. I seem to have vellip that xhtml.ml doesn't. Why is it not used in xml? (IIRC, XML entities have to be declared but it does not harm to decode them even if not, right?)

@Chris00
Copy link
Contributor Author

Chris00 commented Jan 25, 2015

BTW, is there any reason why you used escaped sequences? And why an associative list instead of a more efficient structure?

@Chris00
Copy link
Contributor Author

Chris00 commented Jan 25, 2015

I modified the PR according to the above remarks.

@Chris00 Chris00 changed the title Convert HTML/XML entities by default Use a more efficient datastructure for entity → UTF-8 conversion Jan 25, 2015
@Chris00
Copy link
Contributor Author

Chris00 commented Jan 25, 2015

I thought the Html.html_of_link odd. I added Html.link (from the signature of which it is obvious that one does not need to worry about proper escaping).

This is because it is usually convenient to be able to specify the
HTML last.
@samoht
Copy link
Member

samoht commented Jan 25, 2015

Thanks!

samoht added a commit that referenced this pull request Jan 25, 2015
Use a more efficient datastructure for entity → UTF-8 conversion
@samoht samoht merged commit 807592f into mirage:master Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants