Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
provide deterministic output by using a Map.Make(String) instead of a hashtable #51
the date embedded into a crunched module is either
it is nice to have a
I checked the clients of
In addition, it is noteworthy that if you'd used the API before and wanted to crunch multiple separate artifacts, you'd get the wrong output after the first one, since the hash tables were not cleared between runs. This PR fixes this as well (by making the state explicit).
CHANGES: * Make crunch reproducible: use a Map.Make(String) instead of Hashtbl. Iterating over the former is guaranteed to be sorted over the keys. (mirage/ocaml-crunch#51 @hannesm) * The state (Map.t) is passed explicit to `scan_file`, `output_implementation` and `walk_directory_tree`. The value `empty` is provided to construct an empty `t`. (mirage/ocaml-crunch#51 @hannesm)