Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial ssh (client) support using awa-ssh #362

Open
wants to merge 3 commits into
base: master
from

Conversation

@hannesm
Copy link
Member

commented Jun 27, 2019

ssh.ml is mainly a copy of tcp.ml, some adjustment were needed since in the tcp protocol the client first sends a request, while in ssh a command (git-receive-pack or git-upload-pack) is executed (with the path to the repository as argument) which starts by emitting data.

this means that git-receive/upload-pack needs to be passed while the connection is established (as done with ?cmd here), i.e. before there's a FLOW (or NET as it is called here).

@samoht

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

That looks great!

Do you think we can avoid duplicating some much code in tcp.ml/ssh.ml. The protocols are mostly similar (apart the message prefixes if I remember correctly) so I hope there is a way to share more code :-)

@hannesm

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

@samoht I'd hope so, yes. I don't expect this PR to be merged as is, but would appreciate if someone could think about the code and come up with the right abstractions. please take also the dual PR for conduit/mirage-conduit mirage/ocaml-conduit#296 into consideration.

@hannesm hannesm referenced this pull request Jun 27, 2019

@hannesm hannesm force-pushed the hannesm:awa-future branch from e2a2a47 to 7fc7bb8 Jul 2, 2019

@hannesm hannesm force-pushed the hannesm:awa-future branch from 16a7ac7 to 93008ce Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.