New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic support for IPV6 #9

Merged
merged 4 commits into from Jan 17, 2014

Conversation

Projects
None yet
3 participants
@hhugo
Contributor

hhugo commented Jan 14, 2014

might require more testing

@dsheets

This comment has been minimized.

Member

dsheets commented Jan 14, 2014

Reviewing. Will probably have some patches this afternoon (BST).

@dsheets

This comment has been minimized.

Member

dsheets commented Jan 16, 2014

This was a really superb patch. I very much enjoyed reading it and working on it. Mostly, I cleaned up some style issues. I only found 1 serious bug in the IPv6 prefix membership check but it was easily caught. There were a couple other minor issues but overall I am extremely pleased.

Thank you very much for your contribution, @hhugo. How would you like to be credited?

I have some more test work to do to get better coverage for the new API surface and strengthen the v4 tests with new conventions wrought from v6. See https://github.com/mirage/ocaml-ipaddr/tree/v6.

@avsm

This comment has been minimized.

Member

avsm commented Jan 16, 2014

Thank you very much for your contribution, @hhugo. How would you like to be credited?

I'll second this! Given the size of the patch, I'd suggest adding to the authors list...

@dsheets

This comment has been minimized.

Member

dsheets commented Jan 16, 2014

I've added @hhugo as "Hugo Heuzard" to the _oasis authors list. I hope this name is OK. Whatever future serialization of authors exists, this name will be listed as a major contributor.

@hhugo

This comment has been minimized.

Contributor

hhugo commented Jan 16, 2014

the name is ok. Thanks a lot for your reviews.

@hhugo

This comment has been minimized.

Contributor

hhugo commented Jan 16, 2014

do you plan on releasing 2.0 soon? I'd like to use this in ocsigenserver.

@dsheets

This comment has been minimized.

Member

dsheets commented Jan 16, 2014

Should ship in next 3-4hrs. Still writing tests.

@dsheets dsheets merged commit b14a4b2 into mirage:master Jan 17, 2014

1 check passed

default The Travis CI build passed
Details
@dsheets

This comment has been minimized.

Member

dsheets commented Jan 17, 2014

@hhugo hhugo deleted the hhugo:v6 branch Jan 17, 2014

@avsm

This comment has been minimized.

Member

avsm commented Feb 21, 2014

IPv6 support in DNS was really easy thanks to this!
avsm/ocaml-dns@19b37d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment