New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing memory barriers #122

Open
talex5 opened this Issue Dec 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@talex5
Copy link
Contributor

talex5 commented Dec 18, 2018

All the memory barriers in the vchan source have been commented out. e.g.

(*; Xenctrl.xen_mb ()*)

The log message (0375089) from 2014 says:

The memory barriers are in the xenctrl module at the moment which
seems the wrong place. Additionally, x86 is strongly ordered, so
comment them out for now until we can get the mb operations into a
library elsewhere.

If this library only works reliably on x86, we should probably document that somewhere.

@avsm

This comment has been minimized.

Copy link
Member

avsm commented Dec 27, 2018

Yes indeed. This strongly suggests that the library should be x86_64 only. It would be a nicer fix to dig out the right memory barriers from upstream vchan implementations and put the right ones in this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment