Skip to content

/ ember-cli-mirage

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create extra models in the db when passing association overrides to create #1315

Merged
merged 2 commits into from May 6, 2018
Merged

Don't create extra models in the db when passing association overrides to create #1315

merged 2 commits into from May 6, 2018

Conversation

@happycollision
Copy link
Contributor

@happycollision happycollision commented May 6, 2018 •
edited

This addresses #1298. Hope this change works for you.
@happycollision
Create failing test for issue #1298
5cc5de8
@happycollision
Do not create an association if one is passed in as an override
Loading status checks…
65e844a 
fixes #1298
@happycollision happycollision force-pushed the happycollision:issue-1298 branch from 1e89136 to 65e844a May 6, 2018
@samselikoff samselikoff added the Bug label May 6, 2018
@samselikoff samselikoff merged commit e3023d1 into miragejs:master May 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samselikoff
Copy link
Collaborator

@samselikoff samselikoff commented May 6, 2018

Thank you!
@mehulkar mehulkar mentioned this pull request May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@happycollision @samselikoff