Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

dubious new was generating incomplete skeleton #24

Closed
wants to merge 2 commits into from

3 participants

@ashee

Per our discussion at http://groups.google.com/group/mirah/browse_thread/thread/8f8b95a5be9457a9 I am posting a pull request.

Please note that the Readme.doc has changed since I had to manually build and install the gem from gemspec.

@baroquebobcat

Thanks for pulling your changes into a pull request.

Two comments
1. I want to try to build the next release with a dependency on 0.0.5 of mirah, since that is the released version.
2. my latest checkin should fix rake gem && gem install pkg/dubious-... let me know if it doesn't. It should probably use rake package as that is more general--also, we could make an install rake task that would do it for us, which might make more sense for the README since we wouldn't have to update the version in the docs when it changes

what do you think?

@woodie
Owner

I think we need to push a mirah 0.0.6 gem to get the latest mirah_model changes working. I ran this past ribrdb, he seems to be fine with the idea.

@baroquebobcat

Latest Mirah Model works with 0.0.5, but we can make it self hosted if we pull in ribrdb's changes.

@ashee

baroquebobcat,

I pulled your latest dubious and tried to build it. I gem installed mirah 0.0.5 and mirah_model 0.0.1 (built from source). But it failed as follows

ashee:dubious amitava$ rake package
(in /Users/amitava/opt/dubious)
cp /Users/amitava/opt/mirah_model/lib/mirahdatastore.jar javalib/
rake aborted!
No such file or directory - javalib/mirahdatastore.jar
/Users/amitava/opt/dubious/Rakefile:93
(See full trace by running task with --trace)

ashee:dubious amitava$ rake gem
(in /Users/amitava/opt/dubious)
cp /Users/amitava/opt/mirah_model/lib/mirahdatastore.jar javalib/
rake aborted!
No such file or directory - javalib/mirahdatastore.jar
/Users/amitava/opt/dubious/Rakefile:93
(See full trace by running task with --trace)

@woodie
Owner

I see the same issue:
https://gist.github.com/828001

@baroquebobcat

have fix: 21ebcce#L0L92

forgot to make the javalib directory, which git removed when I removed its contents.

@ashee

Back to square one

ashee:MyCode amitava$ dubious new dbf
create dbf
create dbf/Rakefile
create dbf/app/controllers/application_controller.mirah
create dbf/config/application.properties
(erb):6:in `instance_eval': uninitialized constant ActiveSupport::SecureRandom (NameError)

@baroquebobcat

merged activesupport commit

@ashee

Getting close.

dubious new works and generates the app. But the app keeps reloading the context. Is this normal?

===== Console log snippet ============

IINFO: Successfully processed /Users/amitava/MyCode/dbf/WEB-INF/appengine-web.xml
Feb 15, 2011 8:23:21 PM com.google.apphosting.utils.config.AbstractConfigXmlReader readConfigXml
INFO: Successfully processed /Users/amitava/MyCode/dbf/WEB-INF/web.xml
Feb 15, 2011 8:23:21 PM com.google.appengine.tools.development.JettyContainerService$ApiProxyHandler handle
INFO: Reloaded the webapp context: null

I had to git pull mirah_model to satisfy dubious dependency on mirah_model 0.0.2

mirah_model build seems to successfully build the gem but rake test fails as follows

ashee:mirah_model amitava$ rake test
(in /Users/amitava/opt/mirah_model)
mkdir -p build
Compiling Mirah sources
cd src
mirahc -d /Users/amitava/opt/mirah_model/build /Users/amitava/opt/mirah_model/src/model.mirah
cd -
Building jar: /Users/amitava/opt/mirah_model/lib/mirahdatastore.jar
Compiling Mirah tests
cd test
mirahc -d /Users/amitava/opt/mirah_model/test --classpath /Users/amitava/opt/mirah_model/lib/mirahdatastore.jar /Users/amitava/opt/mirah_model/test/model_test.mirah
/Users/amitava/opt/mirah_model/test/model_test.mirah:31: undefined method literal' for ScopedBody
body:
String("date"):Mirah::AST::ScopedBody
property 'date', Date
^^^^^^^^^^^^^^^^^^^^^^^
error on FunctionalCall(property)(2060)
rake aborted!
undefined method
literal' for ScopedBody
body:
String("date"):Mirah::AST::ScopedBody
/Users/amitava/opt/mirah_model/Rakefile:49
(See full trace by running task with --trace)

@baroquebobcat

the context loading thing is a bug I haven't got to yet. https://github.com/mirah/dubious/issues/issue/26

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 2 deletions.
  1. +2 −1  README.rdoc
  2. +1 −1  dubious.gemspec
  3. +1 −0  lib/dubious/cli.rb
View
3  README.rdoc
@@ -68,7 +68,8 @@ http://code.google.com/appengine/docs/java/configyaml/appconfig_yaml.html
cd -
cd dubious
rake gem
- gem install pkg/dubious-*
+ gem build dubious.gemspec
+ gem install dubious-0.0.2-java.gem
cd -
View
2  dubious.gemspec
@@ -22,6 +22,6 @@ Gem::Specification.new do |s|
s.add_dependency("thor","0.13.8")
s.add_dependency("activesupport")
s.add_dependency("i18n")
- s.add_dependency("mirah", "0.0.5")
+ s.add_dependency("mirah", "0.0.6.dev")
s.add_dependency("appengine-sdk", "~> 1.4.0")
end
View
1  lib/dubious/cli.rb
@@ -1,6 +1,7 @@
require 'thor'
require 'thor/group'
require 'active_support/core_ext'
+require 'active_support'
require File.dirname(__FILE__) + '/cli/init'
require File.dirname(__FILE__) + '/cli/generator'
Something went wrong with that request. Please try again.