From 4fb5fd1a365b55889b632d11ed07239f2582c1bf Mon Sep 17 00:00:00 2001 From: paladox Date: Fri, 3 Nov 2023 21:04:51 +0000 Subject: [PATCH] Fix memory issues under php 8.2 (#433) --- includes/Helpers/ManageWikiOOUIForm.php | 4 +++- maintenance/populateWikiSettings.php | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/includes/Helpers/ManageWikiOOUIForm.php b/includes/Helpers/ManageWikiOOUIForm.php index a22bb6ea2..13d4edae0 100644 --- a/includes/Helpers/ManageWikiOOUIForm.php +++ b/includes/Helpers/ManageWikiOOUIForm.php @@ -97,7 +97,9 @@ public function getButtons() { 'required' => true ]; - $field = $this->addFields( $descriptor )->getField( 'reason' ); + $field = $this->hasField( 'reason' ) ? + $this->getField( 'reason' ) : + $this->addFields( $descriptor )->getField( 'reason' ); $html = $field->getInputOOUI( '' ); diff --git a/maintenance/populateWikiSettings.php b/maintenance/populateWikiSettings.php index e6a166e29..15efaa83d 100644 --- a/maintenance/populateWikiSettings.php +++ b/maintenance/populateWikiSettings.php @@ -33,7 +33,7 @@ public function execute() { foreach ( $settingsource as $input ) { $wikiDB = explode( '|', $input, 2 ); - list( $DBname, $settingvalue ) = array_pad( $wikiDB, 2, '' ); + [ $DBname, $settingvalue ] = array_pad( $wikiDB, 2, '' ); $this->output( "Setting $settingvalue for $DBname\n" );