Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Discord #629

Open
doumr opened this issue Nov 18, 2016 · 28 comments

Comments

@doumr
Copy link

commented Nov 18, 2016

It would be great to have support for Discord (at least for the chat).

  • Discord support
    • General
      • logging in
      • logging out
      • changing status
      • listing friend
      • displaying friends statuses
      • adding users
      • removing users
      • changing nickname
      • editing avatar
      • users avatars
      • displaying user avatars
      • updating user avatars (live when changed)
    • Messaging (general)
      • sending messages
      • recieving messages
      • displaying message editation
      • editing messages ?
      • displaying message removal
      • removing messages ?
      • sending files
      • recieving filies
      • displaying reactions (to messages) ?
      • pinning messages ?
    • Group chats
      • messaging in group chats
      • group chat message markup
      • inviting users
      • changing permissions
      • create channel
      • edit channel
      • remove channel
    • Guilds
      • joining guild
      • leaving guild
      • create guild
      • edit guild
      • remove guild

Note: The TODO list is currently just a raw preview. I will update it to match current state exactly ASAP.

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2016

I second this, as per my thread from here:

http://forum.miranda-ng.org/index.php?topic=4791.0

It's somewhat like an IRC+teamspeak in one, using html5 / websocket. They have a well-documented api: https://discordapp.com/developers/docs/reference and https://discordapp.com/developers/docs/topics/gateway#gateways ).

I had a chat and it probably can be done but our normal model won't work since it uses "WebSocket" api, rather than just a web/rest api.

Any dev interested in this? :3

https://miranda-ng.uservoice.com/forums/250387-general/suggestions/15656175-discord-support
Uservoice post

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2016

I'd like to post a $200 bounty on this - if Discord is supported (groupchats + chats + messagesync) work. I am open to helping with testing.

@georgehazan

This comment has been minimized.

Copy link
Member

commented Dec 21, 2016

@LittleVulpix , okay :) deal

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2017

@georgehazan Bounty paid and received :3 protocol is looking quite good so far. Still stuff left to do but a lot has been done already.

1on1 messaging is working, group chats are being worked on now.

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2017

Groupchats are somewhat working though not (yet) synced. Discord should probably be safe to use soon (if it is not already). I will begin using it shortly and post here about what works and what does not.

Anyone who is interested in discord is also welcome to start testing it!

@Robyer Robyer added the Discord label Feb 7, 2017
@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2017

Filetransfers (i.e. embedding media) are now supported.

@georgehazan

This comment has been minimized.

Copy link
Member

commented Feb 7, 2017

joining / leaving groups is supported

@georgehazan

This comment has been minimized.

Copy link
Member

commented Feb 8, 2017

own nickname's changing is available now via log menu

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2017

We should make some kind of checklist / to-do list to see what's left :o

@Robyer

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

@LittleVulpix You can use "Project" for that checklist/status handling - https://github.com/miranda-ng/miranda-ng/projects , but I'm not sure if you have rights to do that (probably not).

@Goraf

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

@LittleVulpix Use built-in Markdown. But the best place is in the first comment. Not sure if there is a way to move you there

Example:

  • 1on1 messaging
  • Group-chats
    • joining/leaving
@georgehazan

This comment has been minimized.

Copy link
Member

commented Feb 12, 2017

@Goraf @LittleVulpix I don't think that you can join/leave one chat alone, only the whole Guild.
if that's correct, remove two points for them, joining/leaving Guilds is already added.
groupchat message markup is also supported

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2017

Discord is now supported, minus things that are a miranda limitation, including:

  1. A/V (miranda is text-only for now)
  2. Message editing (we receive message edits but don't edit them in db, they simply appear as an extra message, and we cannot edit our own messages)

I think this can be closed as complete. The two points I made above are not directly related to discord (skypeweb and discord both support message edits but miranda does not) and will eventually probably be implemented in a future (long-term future) update.

The proto is fairly ready for normal daily use (I use it on a daily basis and it works pretty well), so any new issues should be raised as an actual separate issue on github.

@doumr , any comments?

@georgehazan georgehazan self-assigned this Feb 22, 2017
@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2017

A second bounty of $200 has been paid thanks to the awesome progression of this plugin, including ( amongst others ) history syncing for groupchats! (though textlogging must be enabled if you want to retain the history, since miranda's profile cannot currently store groupchats).

The last two things I see that are not working correctly (yet): tagging someone ( like @ ) doesn't work as expected and it is also not possible to send a file to a groupchat.

Other than that the plugin is very solid. Thanks again @georgehazan !

@georgehazan

This comment has been minimized.

Copy link
Member

commented Feb 27, 2017

yep, sending files to groupchats is smth that Miranda isn't able to do :-) okay, I'll try to implement it anyhow

@f2d

This comment has been minimized.

Copy link

commented Sep 23, 2017

For Group chats: sending messages with nicknames probably lacks some internal markup, so a non-Miranda user does not get a highlight. I'm using the stable version of plugin, v0.5.0.3 (updated just now).

Highlighting a user seems to take a text form of @name, not usual autoinserted name: etc, but anyway neither works as is outside of Miranda.

There is "highlight user" in right click menu in the chat userlist, but I can't figure out how it works (if it even works).

Also there is a feature in Discord to highlight everyone at once using @everyone, which should probably be made available in that userlist right-click menu. It works as is just by entering text, by the way.

@dartraiden

This comment has been minimized.

Copy link
Member

commented Oct 1, 2017

What about 2-factor authorization?

I found db key MfaEnabled, but I cannot find how to use it.

@georgehazan

This comment has been minimized.

Copy link
Member

commented Oct 1, 2017

this key is read from the server and stored in the profile, dunno what for

@f2d

This comment has been minimized.

Copy link

commented Oct 3, 2017

When someone joins a guild, his nickname in miranda is empty in chat window log and (null) in log file, until my reconnect to server (which can happen several times a day lately). I don't know what it was in group chat userlist, but probably empty, or the userlist was not updated at all.

@f2d

This comment has been minimized.

Copy link

commented Oct 6, 2017

In Discord group chat window, messages like %text, text %text or text 100% - any percent signs collapse with something after (or without) and that combined part is not shown. Mostly eats one symbol, but sometimes a copy of some previous message (part?) is shown instead, probably when a latin letter is interpreted as some variable placeholder.

Anywhere else the text looks correct (as sent) - in Discord group chat log files, in Discord private chats and anywhere in other protocols (i.e. Jabber).

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2017

Yes, I noticed and mentioned this to @georgehazan already. He said that

% should be doubled before sending

@f2d

This comment has been minimized.

Copy link

commented Oct 7, 2017

@LittleVulpix No, it should not. Double %s sent result in double % outside of Miranda, but single % in log file, which seems like additional bug to me. Also the problem affects chat window display of everyone's posts.

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2017

@f2d I didn't propose this change. :p talk to @georgehazan . You should probably log a separate ticket for this.

@f2d

This comment has been minimized.

Copy link

commented Dec 24, 2017

I accidentaly learned, that user mentions are working in format of <@long_Unique_ID_number> with Unique ID from userlist tooltip.

It's a bit cumbersome to type things when a tooltip disappears from keypresses.
Regardless of a full working mention feature, a button to copy this value will be useful.

@ptkovsky

This comment has been minimized.

Copy link

commented May 9, 2018

This is all over the place. Like, I installed this plugin and tried to test some of the basic texting. Sounds simple, isn't it? Well, not really...

Main Miranda window shows a list what is called Chat rooms there (but AFAIK, they are Servers in Discord terminology), but it doesn't show my Friends list, where is it?

When I try to message one of my friends who I found in the Chat room member list (could not find him other way because Friends list is not displayed), it sends all the messages to the other Group I've created earlier (not server, just group), but not to him directly. Why?

Another conversation window popped out with my other friend and it shows that I've messaged him earlier today, but I didn't. It shows this message as a new one, but it's the one I've sent him a few months ago. Really...

What's happening? Seems sort of unusable to me. Sorry guys. Just my first time experience working with this plugin. :)

@LittleVulpix

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2018

It works quite alright, albeit not being exactly user friendly at a first glance. But it works quite okay, I've been using it for the past uhhh... I dunno, several months for sure. No big issues encountered other than the inability to send pictures to group chats (not a discord issue; mostly a problem with how group chats are handled in Miranda), and also the problem with login - oftentimes upon login you will be "kicked" out due to switch of a server - something the web client can do but miranda cannot. @georgehazan any idea on when the server switch without kicking me out could be implemented?

@Evanito

This comment has been minimized.

Copy link

commented Sep 8, 2018

I can't log in, presumably due to 2FA being enabled on my account and I see no option to use it.

@dartraiden

This comment has been minimized.

Copy link
Member

commented Sep 8, 2018

Yes, Miranda NG doesn't support 2FA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.