Allow stacks with a dot in their name #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🦀 Requesting reviewers for this pull request:
|
Madumo
force-pushed
the
fix/body-extract-regex
branch
from
f9d6cdc to
09a621b
Compare
Member
|
Can you add a small test to ensure we do not break this behaviour in the future? |
gingman
approved these changes
Jan 28, 2020
garno
approved these changes
Jan 28, 2020
Boubalou
reviewed
Jan 28, 2020
| default_stacks = Map.get(params, "stacks", "") | ||
|
|
||
| ~r/#dispatch\/(\w+)/i | ||
| ~r/#dispatch\/([\w.]+)/i |
Member
There was a problem hiding this comment.
Une regex... un bug! La saga se poursuit! 🗡
Member
Author
|
@garno Ha! I pushed a test 15 seconds before you submitted your comment 😎 |
Boubalou
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we declare the related stacks of a PR within it's description, the regex to extract those stacks didn't allow for a dot in it's name.
When requesting reviewers for the stack
#dispatch/node.js, the extracted stack name wasnode, notnode.js. Sincenodedidn't match any stacks within our config, it was ignored.This change to the regex will a correctly capture
node.jsinstead of justnode.