Improve ECC support in TLS 1.2 (RFC 8422) #424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go implementation of TLS dislikes client hello without a ECPointFormats extension, so let's revert from mirleft#413 and re-add this extension with a single value (uncompressed) to client hello (and server hello if client sent it, and an ECC ciphersuite was selected). In TLS 1.3 only settings, this change is a no-op.
Member
Author
|
merged manually |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 8, 2020
CHANGES: * Re-add ECPointFormats hello extension (both client and server) to avoid handshake failures with Go's TLS stack (RFC 8422 makes it optional, but go (1.15.5) requires it) - reported by @jeffa5 at https://discuss.ocaml.org/t/strange-prohibited-tls-1-2-cipher-suite-9d-issue/ fix by @hannesm mirleft/ocaml-tls#424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go implementation of TLS dislikes client hello without a ECPointFormats
extension, so let's revert from #413 and re-add this extension with a single
value (uncompressed) to client hello (and server hello if client sent it, and
an ECC ciphersuite was selected).
In TLS 1.3 only settings, this change is a no-op.