use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
changed the title
…n type (using a tuple, records are so noisy) - thx to @NathanReb for the suggestion
… variant (the rdnsequence is merged into a single map, last one wins)
…ule; provide Signing_request.Ext.pp : t Fmt.t
…istinguished_name
|
while re-reading the PR and RFC 5280 again, I discovered that the CRLissuer in the distributionPoint extension is a GeneralName (not a DistinguishedName) - fixed in a commit above, and also printing of DistinguishedName.t now uses |
… test whether the implicit vs explicit works as expected (the CA cert is taken from my /etc/ssl/certs.pem)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.