Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) #115

Merged
merged 17 commits into from Jul 24, 2019

Conversation

@hannesm
Copy link
Member

commented Jun 28, 2019

No description provided.

@hannesm hannesm force-pushed the hannesm:gmap-extension branch from 3821126 to 6d8c245 Jun 30, 2019

@hannesm hannesm changed the title use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) Jul 1, 2019

@hannesm hannesm force-pushed the hannesm:gmap-extension branch from bdc3bf2 to 4521334 Jul 8, 2019

@hannesm hannesm force-pushed the hannesm:gmap-extension branch from d486b26 to b01455f Jul 24, 2019

@hannesm

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

while re-reading the PR and RFC 5280 again, I discovered that the CRLissuer in the distributionPoint extension is a GeneralName (not a DistinguishedName) - fixed in a commit above, and also printing of DistinguishedName.t now uses / as separator, as commonly used by other tools. i plan to merge and release this later today unless there's any substantiated objection (or travis complains).

hannesm added some commits Jul 24, 2019

add a test case with SubjectAlternativeName containing a directory to…
… test whether the implicit vs explicit works as expected (the CA cert is taken from my /etc/ssl/certs.pem)

@hannesm hannesm merged commit 7e19906 into mirleft:master Jul 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.