Skip to content

use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 24, 2019
Merged

use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) #115

merged 17 commits into from
Jul 24, 2019

Conversation

@hannesm
Copy link
Member

@hannesm hannesm commented Jun 28, 2019

No description provided.

@hannesm hannesm changed the title use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t use gmap for Extension.t, General_name.t, Distinguished_name.t and Signing_request.Ext.t; also use Domain_name (instead of string) and Ipaddr (instead of cstruct) Jul 1, 2019
hannesm added 14 commits July 24, 2019 09:38
@hannesm
rename: CA to Signing_request
09cb262
@hannesm
extension is now a gmap
a352504
@hannesm
Extension: make critical flag more explicit by a polymorphic extensio…
eaa6ec9 
…n type (using a tuple, records are so noisy) - thx to @NathanReb for the suggestion
@hannesm
Signing_request.request_extensions is now a Gmap Signing_request.Ext
ba5e3b7
@hannesm
distinguished_name: now a GADT, no longer a list of a big polymorphic…
27d3745 
… variant (the rdnsequence is merged into a single map, last one wins)
@hannesm
general_name is now a GADT
7919b37
@hannesm
Extension: adjust pp to be t Fmt.t ; general_name: move to custom mod…
aefa70e 
…ule; provide Signing_request.Ext.pp : t Fmt.t
@hannesm
use domain-name library for hostnames
7ce9dd8
@hannesm
remove bisect from dune
65c1631
@hannesm
qualify for <= 4.06 compability
452ab13
@hannesm
use ipaddr.t as General_name IP data (instead of Cstruct.t)
8167888
@hannesm
fix typo
70cce56
@hannesm
CRLissuer (in distributionPoint extension) is a General_name, not a D…
85b5e94 
…istinguished_name
@hannesm
print Distinguished_name.t with '/' as separator between components
b01455f
@hannesm
Copy link
Member Author

hannesm commented Jul 24, 2019

while re-reading the PR and RFC 5280 again, I discovered that the CRLissuer in the distributionPoint extension is a GeneralName (not a DistinguishedName) - fixed in a commit above, and also printing of DistinguishedName.t now uses / as separator, as commonly used by other tools. i plan to merge and release this later today unless there's any substantiated objection (or travis complains).

hannesm added 3 commits July 24, 2019 15:12
@hannesm
add a test case with SubjectAlternativeName containing a directory to…
5d910c9 
… test whether the implicit vs explicit works as expected (the CA cert is taken from my /etc/ssl/certs.pem)
@hannesm
result in Msg of string instead of Asn's Parse of string
48bc71b
@hannesm
add missing docstrings
18c2909
@hannesm hannesm merged commit 7e19906 into mirleft:master Jul 24, 2019
@hannesm hannesm mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hannesm