DetailsList: fix exception in DetailsRow when selection is undefined. (…

…microsoft#14088) * fix exception with selection is undefined * Change files
miroslavstastny · Jul 20, 2020 · 3a9feb3 · 3a9feb3
1 parent 4a6bdec
commit 3a9feb3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/change/office-ui-fabric-react-2020-07-17-09-23-46-xgao-details-row.json b/change/office-ui-fabric-react-2020-07-17-09-23-46-xgao-details-row.json
@@ -0,0 +1,8 @@
+{
+  "type": "patch",
+  "comment": "DetailsList: fix exception in DetailsRow when selection is undefined.",
+  "packageName": "office-ui-fabric-react",
+  "email": "xgao@microsoft.com",
+  "dependentChangeType": "patch",
+  "date": "2020-07-17T16:23:46.317Z"
+}
diff --git a/packages/office-ui-fabric-react/src/components/DetailsList/DetailsRow.base.tsx b/packages/office-ui-fabric-react/src/components/DetailsList/DetailsRow.base.tsx
@@ -74,7 +74,7 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai
   }
 
   public componentDidMount(): void {
-    const { dragDropHelper } = this.props;
+    const { dragDropHelper, selection, item, onDidMount } = this.props;
 
     if (dragDropHelper) {
       this._dragDropSubscription = dragDropHelper.subscribe(
@@ -84,12 +84,14 @@ export class DetailsRowBase extends React.Component<IDetailsRowBaseProps, IDetai
       );
     }
 
-    this._events.on(this.props.selection, SELECTION_CHANGE, this._onSelectionChanged);
+    if (selection) {
+      this._events.on(selection, SELECTION_CHANGE, this._onSelectionChanged);
+    }
 
-    if (this.props.onDidMount && this.props.item) {
+    if (onDidMount && item) {
       // If the item appears later, we should wait for it before calling this method.
       this._onDidMountCalled = true;
-      this.props.onDidMount(this);
+      onDidMount(this);
     }
   }