Skip to content

Using default ROS repos #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

Using default ROS repos #6

merged 1 commit into from
Jun 27, 2023

Conversation

@mklomp
Copy link
Contributor

@mklomp mklomp commented Jun 21, 2023

No description provided.

@mklomp mklomp requested a review from ArendJan June 21, 2023 08:08
@ArendJan
Copy link
Contributor

ArendJan commented Jun 24, 2023

Seems okay, but why twice?
The download_repos file is run from mirte_install.sh, just like install_ROS.sh.

@mklomp
Copy link
Contributor Author

mklomp commented Jun 26, 2023

At the moment I would like to have all script be able to run independently. This is why both scripts need the ROS repo installed. We might consider doing this in another way later.

@ArendJan ArendJan merged commit dd24daf into mirte-robot:main Jun 27, 2023
@mklomp mklomp deleted the ros_repo_fixes branch June 27, 2023 10:02
ArendJan added a commit that referenced this pull request Mar 4, 2025
@ArendJan
Takeaways from proj rob branch #6
6ffc7db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArendJan ArendJan ArendJan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mklomp @ArendJan