Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Category sitemap #1447

Merged
merged 4 commits into from Dec 12, 2017
Merged

Conversation

Pacu2
Copy link
Contributor

@Pacu2 Pacu2 commented Dec 7, 2017

Close #1446
Categories are included in sitemap:
categories_in_sitemap

(Please mention all relevant issue numbers.)

(If your changes affect the UI, providing "before" and "after" screenshots will
greatly reduce the amount of work needed to review your work.)

Pull Request Checklist

(Please keep this section. It will make maintainer's life easier.)

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #1447 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage    83.4%   83.42%   +0.02%     
==========================================
  Files         128      128              
  Lines        5791     5799       +8     
  Branches      664      665       +1     
==========================================
+ Hits         4830     4838       +8     
  Misses        803      803              
  Partials      158      158
Impacted Files Coverage Δ
saleor/core/sitemaps.py 100% <100%> (ø) ⬆️
saleor/product/models.py 92.16% <0%> (-0.06%) ⬇️
saleor/search/backends/postgresql_dashboard.py 100% <0%> (ø) ⬆️
saleor/dashboard/search/views.py 90.9% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d167c...e1383fe. Read the comment docs.

@Pacu2 Pacu2 removed the in progress label Dec 7, 2017
Copy link
Member

@patrys patrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also prevent search engines from indexing filtered category lists (maybe link their unfiltered versions as canonical).

@Pacu2
Copy link
Contributor Author

Pacu2 commented Dec 7, 2017

@patrys already on it #1345

@maarcingebala maarcingebala merged commit 489c19d into saleor:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants