New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust minimum validators on CartLine, OrderLine and FulfillmentLine #2925
Conversation
I think you need to include migrations for those changes. |
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 208 208
Lines 10728 10728
Branches 1039 1039
=======================================
Hits 9616 9616
Misses 792 792
Partials 320 320
Continue to review full report at Codecov.
|
4a8aa13
to
b67ac1f
Compare
Yeah, that's right. What do you think about writing tests for models with simple logic like this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could also remove MaxValueValidator, not sure what they're for? What do you think @maarcingebala ?
@Pacu2 Yeah, I guess we could drop them. Would you mind removing them @the-bionic? |
I'll do that right away. |
How about dropping the |
8dfa526
to
eddf637
Compare
@the-bionic Yes please |
3821e17
to
2d79106
Compare
0940405
to
2767d6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you please rebase with the latest master? I think we are already on 61st migration in orders
2767d6f
to
f165f06
Compare
f165f06
to
36c9bd2
Compare
Thank you for picking this up! |
Glad to be of assistance. |
I want to merge this change because...
close #2912
Screenshots
Pull Request Checklist