Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation discard button #4109

Merged
merged 6 commits into from May 15, 2019
Merged

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented May 14, 2019

Resolves: #4013

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #4109 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4109      +/-   ##
==========================================
+ Coverage   91.52%   91.58%   +0.05%     
==========================================
  Files         277      277              
  Lines       15083    15132      +49     
  Branches     1479     1482       +3     
==========================================
+ Hits        13805    13858      +53     
+ Misses        874      872       -2     
+ Partials      404      402       -2
Impacted Files Coverage Δ
saleor/payment/gateways/braintree/__init__.py 100% <0%> (ø) ⬆️
saleor/graphql/order/types.py 84.31% <0%> (ø) ⬆️
saleor/payment/interface.py 100% <0%> (ø) ⬆️
saleor/payment/gateways/razorpay/__init__.py 98.5% <0%> (+0.14%) ⬆️
saleor/payment/gateways/stripe/__init__.py 98.95% <0%> (+0.16%) ⬆️
saleor/payment/utils.py 92.13% <0%> (+0.63%) ⬆️
saleor/payment/models.py 96.84% <0%> (+1.99%) ⬆️
saleor/payment/gateways/dummy/__init__.py 100% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887f2a0...207ccf4. Read the comment docs.

@benekex2 benekex2 changed the title Fix translation discard btn Fix translation discard button May 15, 2019
@maarcingebala maarcingebala merged commit f915620 into master May 15, 2019
@maarcingebala maarcingebala deleted the fix-translation-discard-btn branch May 15, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Discard changes" button doesn't work
4 participants