unicode is str in Python3
#887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleor/discount/forms.py
Outdated
| @@ -38,7 +39,7 @@ def clean(self): | |||
| discount = voucher.get_discount_for_checkout(self.checkout) | |||
| cleaned_data['discount'] = discount | |||
| except NotApplicable as e: | |||
| self.add_error('voucher', unicode(e)) | |||
| self.add_error('voucher', six.text_type(e)) | |||
There was a problem hiding this comment.
Could you use smart_text from django.utils.encoding? That's what we use in rest of the project.
There was a problem hiding this comment.
@krzysztofwolski Ok, done.
Codecov Report@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 59.11% 59.14% +0.02%
==========================================
Files 109 109
Lines 5944 5945 +1
Branches 722 722
==========================================
+ Hits 3514 3516 +2
+ Misses 2292 2290 -2
- Partials 138 139 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix discount error message and add a test